Re: v16 fails to build w/ Visual Studio 2015

2023-06-11 Thread Michael Paquier
On Wed, Jun 07, 2023 at 03:04:16PM -0700, Noah Misch wrote: > On Wed, Jun 07, 2023 at 11:34:09PM +0200, Peter Eisentraut wrote: >> Apparently, nobody has used it between Sat Jul 9 08:52:19 2022 and now? One week close enough. I have run checks on VS 2015 back when working on 6203583, but I don't

Re: v16 fails to build w/ Visual Studio 2015

2023-06-11 Thread Michael Paquier
On Wed, Jun 07, 2023 at 11:35:34PM +0200, Peter Eisentraut wrote: > I kind of like the style where there is only one return at the end, because > it makes it easier to inject debugging code that inspects the return value. I kind of disagree here, the previous style is a bit ugly-ish, with the code

Re: v16 fails to build w/ Visual Studio 2015

2023-06-07 Thread Noah Misch
On Wed, Jun 07, 2023 at 11:34:09PM +0200, Peter Eisentraut wrote: > On 07.06.23 23:21, Andres Freund wrote: > >On 2023-06-07 11:54:58 -0700, Noah Misch wrote: > >>Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler > >>bug that causes the build to fail with "readfuncs.switc

Re: v16 fails to build w/ Visual Studio 2015

2023-06-07 Thread Peter Eisentraut
On 07.06.23 23:16, Tom Lane wrote: Noah Misch writes: Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler bug that causes the build to fail with "readfuncs.switch.c(522): fatal error C1026: parser stack overflow, program too complex (compiling source file src/backend/no

Re: v16 fails to build w/ Visual Studio 2015

2023-06-07 Thread Peter Eisentraut
On 07.06.23 23:21, Andres Freund wrote: On 2023-06-07 11:54:58 -0700, Noah Misch wrote: Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler bug that causes the build to fail with "readfuncs.switch.c(522): fatal error C1026: parser stack overflow, program too complex (com

Re: v16 fails to build w/ Visual Studio 2015

2023-06-07 Thread Andres Freund
Hi, On 2023-06-07 11:54:58 -0700, Noah Misch wrote: > Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler > bug that causes the build to fail with "readfuncs.switch.c(522): fatal error > C1026: parser stack overflow, program too complex (compiling source file > src/backend

Re: v16 fails to build w/ Visual Studio 2015

2023-06-07 Thread Tom Lane
Noah Misch writes: > Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler > bug that causes the build to fail with "readfuncs.switch.c(522): fatal error > C1026: parser stack overflow, program too complex (compiling source file > src/backend/nodes/readfuncs.c)". While I wo