Re: v14 mechanical code beautification patches

2021-05-06 Thread Bruce Momjian
On Wed, May 5, 2021 at 10:45:01PM -0400, Tom Lane wrote: > I located the "current" versions of those files in libbind 6.0. > (I put "current" in quotes because the file dates seem to be > 2005-2008, so indeed development came to a stop a long time ago.) > > They are *very* different from what we

Re: v14 mechanical code beautification patches

2021-05-05 Thread Tom Lane
I wrote: > I dug in the archives and found the thread that prompted you to > add that bullet item: > https://www.postgresql.org/message-id/200502021700.j12H05j20872%40candle.pha.pa.us > which made the point that those were moving targets back in 2005. > I doubt they still are, so I don't see much p

Re: v14 mechanical code beautification patches

2021-05-05 Thread Bruce Momjian
On Wed, May 5, 2021 at 07:08:35PM -0400, Tom Lane wrote: > > I think it is related to these files: > > src/backend/utils/adt/inet_cidr_ntop.c > > src/backend/utils/adt/inet_net_pton.c > > which have at the top: > > * Copyright (c) 2004 by Internet Systems Consortium, Inc. ("ISC") > > * C

Re: v14 mechanical code beautification patches

2021-05-05 Thread Tom Lane
Bruce Momjian writes: > On Wed, May 5, 2021 at 02:18:04PM -0400, Tom Lane wrote: >> I notice that we also list this as a pre-beta task in >> src/tools/RELEASE_CHANGES: >> * Update inet/cidr data types with newest Bind patches >> However, I can't recall that anyone has ever done any such thin

Re: v14 mechanical code beautification patches

2021-05-05 Thread Bruce Momjian
On Wed, May 5, 2021 at 02:18:04PM -0400, Tom Lane wrote: > I notice that we also list this as a pre-beta task in > src/tools/RELEASE_CHANGES: > > * Update inet/cidr data types with newest Bind patches > > However, I can't recall that anyone has ever done any such thing; > and at this point, any