On 2020-Sep-09, Justin Pryzby wrote:
> As for the discussion about a separator, I think maybe a comma is enough. I
> doubt anyone is going to think that you can get a valid command by prefixing
> this by "CREATE STATISTICS". Actually, it didn't even occur to me it was
> valid
> command without
‐‐‐ Original Message ‐‐‐
On Thursday, 10 September 2020 00:36, Justin Pryzby
wrote:
> On Tue, Sep 01, 2020 at 12:35:19PM +, Georgios Kokolatos wrote:
>
> > I will humbly disagree with the current review. I shall refrain from
> > changing the status though because I do not have ve
On Wed, Sep 09, 2020 at 07:22:30PM -0300, Alvaro Herrera wrote:
> On 2020-Sep-09, Justin Pryzby wrote:
>
> > As for the discussion about a separator, I think maybe a comma is enough. I
> > doubt anyone is going to think that you can get a valid command by prefixing
> > this by "CREATE STATISTICS"
On 2020-Sep-09, Justin Pryzby wrote:
> As for the discussion about a separator, I think maybe a comma is enough. I
> doubt anyone is going to think that you can get a valid command by prefixing
> this by "CREATE STATISTICS". Actually, it didn't even occur to me it was
> valid
> command without
On 2020-Sep-09, Justin Pryzby wrote:
> As for the discussion about a separator, I think maybe a comma is enough. I
> doubt anyone is going to think that you can get a valid command by prefixing
> this by "CREATE STATISTICS". Actually, it didn't even occur to me it was
> valid
> command without
On Tue, Sep 01, 2020 at 12:35:19PM +, Georgios Kokolatos wrote:
> I will humbly disagree with the current review. I shall refrain from changing
> the status though because I do not have very strong feeling about it.
Sorry but this was in my spam, and didn't see until now.
>
> However the pa
On Sun, Sep 6, 2020 at 1:48 PM Justin Pryzby wrote:
> On Sun, Sep 06, 2020 at 01:06:05PM -0700, Peter Geoghegan wrote:
> > How about a line break? That seems like a simple solution that takes
> > all the competing concerns into account.
> Like this ?
> Statistics objects:
> "public"."t" (ndi
On Sun, Sep 06, 2020 at 01:06:05PM -0700, Peter Geoghegan wrote:
> On Tue, Sep 1, 2020 at 2:08 PM Alvaro Herrera
> wrote:
> > It does need some separator. Maybe a comma is sufficient, but I'm not
> > sure: that will fail when we add cross-relation stats, because the
> > FROM clause will have mor
On Tue, Sep 1, 2020 at 2:08 PM Alvaro Herrera wrote:
> It does need some separator. Maybe a comma is sufficient, but I'm not
> sure: that will fail when we add cross-relation stats, because the
> FROM clause will have more relations and possibly have commas too.
How about a line break? That seem
On Tue, Sep 01, 2020 at 05:08:25PM -0400, Alvaro Herrera wrote:
> +1 on fixing this, since the ability to change stats target is new in
> pg13.
>
> On 2020-Aug-31, Justin Pryzby wrote:
>
> > Maybe it should have a comma, like ", STATISTICS %s"?
>
> It does need some separator. Maybe a comma is
On Tue, Sep 01, 2020 at 05:08:25PM -0400, Alvaro Herrera wrote:
+1 on fixing this, since the ability to change stats target is new in
pg13.
On 2020-Aug-31, Justin Pryzby wrote:
Maybe it should have a comma, like ", STATISTICS %s"?
It does need some separator. Maybe a comma is sufficient, bu
+1 on fixing this, since the ability to change stats target is new in
pg13.
On 2020-Aug-31, Justin Pryzby wrote:
> Maybe it should have a comma, like ", STATISTICS %s"?
It does need some separator. Maybe a comma is sufficient, but I'm not
sure: that will fail when we add cross-relation stats, b
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hi,
I will humbly disagree with the current review. I shall refrain from cha
Hi Justin,
On 2020/08/31 14:00, Justin Pryzby wrote:
The stats target can be set since commit d06215d03, but wasn't shown by psql.
ALTER STATISISTICS .. SET STATISTICS n.
Normal (1-D) stats targets are shown in \d+ table.
Stats objects are shown in \d (no plus).
Arguably, this should be shown
On Mon, Aug 31, 2020 at 07:47:35AM +, gkokola...@pm.me wrote:
> ‐‐‐ Original Message ‐‐‐
> On Monday, 31 August 2020 08:00, Justin Pryzby wrote:
>
> > The stats target can be set since commit d06215d03, but wasn't shown by
> > psql.
> > ALTER STATISISTICS .. SET STATISTICS n.
> >
> >
‐‐‐ Original Message ‐‐‐
On Monday, 31 August 2020 08:00, Justin Pryzby wrote:
> The stats target can be set since commit d06215d03, but wasn't shown by psql.
> ALTER STATISISTICS .. SET STATISTICS n.
>
> Normal (1-D) stats targets are shown in \d+ table.
> Stats objects are shown i
16 matches
Mail list logo
