Re: v12 pg_basebackup fails against older servers (take two)

2019-10-23 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Oct 22, 2019 at 09:53:45AM -0400, Stephen Frost wrote: > > Yeah.. Something along those lines definitely seems like it'd be better > > as that would force anyone adding new options to explicitly say which > > server version the o

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Michael Paquier
On Tue, Oct 22, 2019 at 09:53:45AM -0400, Stephen Frost wrote: > Yeah.. Something along those lines definitely seems like it'd be better > as that would force anyone adding new options to explicitly say which > server version the option makes sense for. Would it make sense to have a > minimum and

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Oct 22, 2019 at 09:06:03AM -0400, Stephen Frost wrote: > > Here's just a quick rough-up of a patch (it compiles, I haven't tried it > > out more than that) that adds in a check to skip gssencmode on older > > versions. If it seem

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Michael Paquier
On Tue, Oct 22, 2019 at 09:06:03AM -0400, Stephen Frost wrote: > Here's just a quick rough-up of a patch (it compiles, I haven't tried it > out more than that) that adds in a check to skip gssencmode on older > versions. If it seems like a reasonable approach then I can test it out > and deal with

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Stephen Frost
Greetings, * Devrim Gündüz (dev...@gunduz.org) wrote: > On Tue, 2019-10-22 at 19:16 +0900, Michael Paquier wrote: > > You are referring to the connection string generated in > > primary_conninfo here, right? > > Right. I'm awful suspicious that there's other similar cases beyond this particular

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Devrim Gündüz
Hi, On Tue, 2019-10-22 at 19:16 +0900, Michael Paquier wrote: > You are referring to the connection string generated in > primary_conninfo here, right? Right. > It would be nice to be more compatible here. This can be simply fixed by > having an extra filter in GenerateRecoveryConfig() (differ

Re: v12 pg_basebackup fails against older servers (take two)

2019-10-22 Thread Michael Paquier
On Tue, Oct 22, 2019 at 12:32:53PM +0300, Devrim Gündüz wrote: > When I run pg_basebackup in v12 against v11, standby server fails to connecto > primary with the following error: > > 2019-10-22 09:28:23.673 UTC [2375] FATAL: could not connect to the primary > server: invalid connection option "gs