Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-11-04 Thread Michael Paquier
On Sat, Nov 02, 2019 at 05:19:11PM +0900, Michael Paquier wrote: > Sounds fine. So gathering everything I get the attached. Any > thoughts from others? Committed after splitting the changes in two as originally proposed. -- Michael signature.asc Description: PGP signature

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-11-02 Thread Michael Paquier
On Fri, Nov 01, 2019 at 11:58:43AM -0500, Justin Pryzby wrote: > Attaching a partition acquires a SHARE UPDATE EXCLUSIVE > lock > on the parent table, in addition to ACCESS EXCLUSIVE locks > on the table to be attached and the DEFAULT partition (if > any).

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-11-01 Thread Justin Pryzby
On Fri, Nov 01, 2019 at 11:01:22PM +0900, Michael Paquier wrote: > On Fri, Nov 01, 2019 at 08:59:48AM -0500, Justin Pryzby wrote: > > I guess you mean because it's not a child until after the ALTER. Yes, that > > makes sense. > > Yes, perhaps you have another idea than mine on how to shape this >

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-11-01 Thread Michael Paquier
On Fri, Nov 01, 2019 at 08:59:48AM -0500, Justin Pryzby wrote: > I guess you mean because it's not a child until after the ALTER. Yes, that > makes sense. Yes, perhaps you have another idea than mine on how to shape this sentence? -- Michael signature.asc Description: PGP signature

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-11-01 Thread Justin Pryzby
On Thu, Oct 31, 2019 at 06:07:34PM +0900, Michael Paquier wrote: > On Mon, Oct 28, 2019 at 10:56:33PM -0500, Justin Pryzby wrote: > > I suppose it should something other than partition(ed), since partitions > > can be > > partitioned, too... > > > > Attaching a partition acquires a SHARE UP

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-10-31 Thread Michael Paquier
On Mon, Oct 28, 2019 at 10:56:33PM -0500, Justin Pryzby wrote: > I suppose it should something other than partition(ed), since partitions can > be > partitioned, too... > > Attaching a partition acquires a SHARE UPDATE > EXCLUSIVE > lock on the parent table, in addition to > AC

Re: update ALTER TABLE with ATTACH PARTITION lock mode

2019-10-31 Thread Amit Langote
Hello, On Tue, Oct 29, 2019 at 12:13 AM Alvaro Herrera wrote: > On 2019-Oct-28, Michael Paquier wrote: > > On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote: > > > commit #898e5e32 (Allow ATTACH PARTITION with only > > > ShareUpdateExclusiveLock) > > > updates ddl.sgml but not alter_

Re: update ALTER TABLE with ATTACH PARTITION lock mode (docs)

2019-10-28 Thread Justin Pryzby
On Mon, Oct 28, 2019 at 12:06:44PM -0300, Alvaro Herrera wrote: > On 2019-Oct-28, Michael Paquier wrote: > > > On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote: > > > commit #898e5e32 (Allow ATTACH PARTITION with only > > > ShareUpdateExclusiveLock) > > > updates ddl.sgml but not alt

Re: update ALTER TABLE with ATTACH PARTITION lock mode

2019-10-28 Thread Alvaro Herrera
On 2019-Oct-28, Michael Paquier wrote: > On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote: > > commit #898e5e32 (Allow ATTACH PARTITION with only ShareUpdateExclusiveLock) > > updates ddl.sgml but not alter_table.sgml, which only says: > > > > https://www.postgresql.org/docs/12/relea

Re: update ALTER TABLE with ATTACH PARTITION lock mode

2019-10-28 Thread Michael Paquier
On Sun, Oct 27, 2019 at 07:12:07PM -0500, Justin Pryzby wrote: > commit #898e5e32 (Allow ATTACH PARTITION with only ShareUpdateExclusiveLock) > updates ddl.sgml but not alter_table.sgml, which only says: > > https://www.postgresql.org/docs/12/release-12.html > |An ACCESS EXCLUSIVE lock is held unl