Re: upcoming API changes for LLVM 12

2020-12-07 Thread Andres Freund
Hi, On 2020-11-09 20:13:43 -0800, Andres Freund wrote: > I pushed the change to master. If that doesn't show any problems, I'll > backpatch in a week or so. Seawasp runs only on master, so it should > satisfy the buildfarm at least. It was a bit longer than a week, but I finally have done so... L

Re: upcoming API changes for LLVM 12

2020-11-09 Thread Tom Lane
Andres Freund writes: > I pushed the change to master. Thanks! > If that doesn't show any problems, I'll > backpatch in a week or so. Seawasp runs only on master, so it should > satisfy the buildfarm at least. Yeah, sounds like a good plan. FWIW, master builds clean for me.

Re: upcoming API changes for LLVM 12

2020-11-09 Thread Andres Freund
Hi, On 2020-11-08 18:22:50 -0500, Tom Lane wrote: > Andres Freund writes: > > Yea, I'll try to do that in the next few days I pushed the change to master. If that doesn't show any problems, I'll backpatch in a week or so. Seawasp runs only on master, so it should satisfy the buildfarm at least.

Re: upcoming API changes for LLVM 12

2020-11-08 Thread Tom Lane
Andres Freund writes: > Yea, I'll try to do that in the next few days (was plannin to last week, > but due to a hand injury I was typing one handed last week - makes it > pretty annoying to clean up code. But I just started being able to at > least use my left thumb again...). Ouch. Get well soo

Re: upcoming API changes for LLVM 12

2020-11-08 Thread Andres Freund
Hi, On 2020-11-08 17:35:20 -0500, Tom Lane wrote: > I suppose this is related to what you are talking about here. Yes. > If so, could we prioritize getting that committed? It's annoying > to have the buildfarm failures page so full of this one issue. Yea, I'll try to do that in the next few d

Re: upcoming API changes for LLVM 12

2020-11-08 Thread Tom Lane
Andres Freund writes: > On 2020-11-02 10:28:33 -0800, Jesse Zhang wrote: >> On Thu, Oct 15, 2020 at 6:12 PM Andres Freund wrote: >>> There will be a breaking API change for JIT related API in LLVM >>> 12. seawasp, which runs some bleeding-edge version of clang, has been falling over for the last

Re: upcoming API changes for LLVM 12

2020-11-02 Thread Andres Freund
Hi, On 2020-11-02 10:28:33 -0800, Jesse Zhang wrote: > On Thu, Oct 15, 2020 at 6:12 PM Andres Freund wrote: > > There will be a breaking API change for JIT related API in LLVM > > 12. Mostly about making control over various aspects easier, and then > > building on top of that providing new featu

Re: upcoming API changes for LLVM 12

2020-11-02 Thread Jesse Zhang
Hi Andres, On Thu, Oct 15, 2020 at 6:12 PM Andres Freund wrote: > > Hi, > > There will be a breaking API change for JIT related API in LLVM > 12. Mostly about making control over various aspects easier, and then > building on top of that providing new features (like JIT compiling in > the backgro

Re: upcoming API changes for LLVM 12

2020-10-16 Thread Alvaro Herrera
On 2020-Oct-16, Andres Freund wrote: > A related question is whether it'd be time to prune the oldest supported > LLVM version. 3.9.0 was released 2016-08-31 (and 3.9.1, the only point > release, was 2016-12-13). There's currently no *pressing* reason to > reduce it, but it is the cause of few #if

Re: upcoming API changes for LLVM 12

2020-10-16 Thread Tom Lane
Andres Freund writes: > A related question is whether it'd be time to prune the oldest supported > LLVM version. 3.9.0 was released 2016-08-31 (and 3.9.1, the only point > release, was 2016-12-13). There's currently no *pressing* reason to > reduce it, but it is the cause of few #ifdefs - but more

Re: upcoming API changes for LLVM 12

2020-10-16 Thread Andres Freund
Hi, On 2020-10-16 10:22:57 -0400, Tom Lane wrote: > Yeah. As long as we're not breaking the ability to build against older > LLVM, I can't see a reason not to apply and back-patch these changes. > We usually want all supported PG versions to build against newer tool > chains, and this seems to fa

Re: upcoming API changes for LLVM 12

2020-10-16 Thread Tom Lane
Andres Freund writes: > On 2020-10-16 02:45:51 -0300, Alvaro Herrera wrote: >>> 2) When do we want to add LLVM 12 support? PG will soon stop compiling >>> against LLVM 12, which will be released in about 6 months. I worked >>> with Lang to make most of the breaking changes in a branch (to be >>> m

Re: upcoming API changes for LLVM 12

2020-10-16 Thread Andres Freund
Hi, On 2020-10-16 02:45:51 -0300, Alvaro Herrera wrote: > Whee, sounds pretty good ... (am I dreaming too much if I hope > execution starts with non-jitted and switches on the fly to jitted > once background compilation finishes?) There's some more work needed to get there, but yes, the basics fo

Re: upcoming API changes for LLVM 12

2020-10-15 Thread Alvaro Herrera
On 2020-Oct-15, Andres Freund wrote: > There will be a breaking API change for JIT related API in LLVM > 12. Mostly about making control over various aspects easier, and then > building on top of that providing new features (like JIT compiling in > the background and making it easier to share JIT

Re: upcoming API changes for LLVM 12

2020-10-15 Thread Thomas Munro
On Fri, Oct 16, 2020 at 2:12 PM Andres Freund wrote: > There will be a breaking API change for JIT related API in LLVM > 12. Mostly about making control over various aspects easier, and then > building on top of that providing new features (like JIT compiling in > the background and making it easi