On 2025/03/04 17:57, jian he wrote:
On Mon, Mar 3, 2025 at 5:05 PM Fujii Masao wrote:
Thanks for the patch!
The patch basically looks good to me.
I’ve made some minor cosmetic adjustments — the updated patch is attached.
Unless there are any objections, I'm thinking to commit it.
I che
po 3. 3. 2025 v 10:05 odesílatel Fujii Masao
napsal:
>
>
>
> On 2025/01/10 23:50, jian he wrote:
> > hi.
> > seems no regress tests for pg_stat_progress_copy.tuples_skipped.
> >
> > CopyFrom
> > pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED,
> >cstate->n
On Mon, Mar 3, 2025 at 5:05 PM Fujii Masao wrote:
>
> Thanks for the patch!
>
> The patch basically looks good to me.
> I’ve made some minor cosmetic adjustments — the updated patch is attached.
>
> Unless there are any objections, I'm thinking to commit it.
>
I checked it again manually.
It look
On 2025/01/10 23:50, jian he wrote:
hi.
seems no regress tests for pg_stat_progress_copy.tuples_skipped.
CopyFrom
pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED,
cstate->num_errors);
there is coverage for it. but in regress test, we didn't really prin