Re: test_escape: invalid option -- 'c'

2025-02-18 Thread Michael Paquier
On Wed, Feb 19, 2025 at 10:31:40AM +0800, Japin Li wrote: > I didn't add the 'f' option since the usage() does not declare it. > If you add this, we also should update the usage(), right? Yes, we should. -- Michael signature.asc Description: PGP signature

Re: test_escape: invalid option -- 'c'

2025-02-18 Thread Japin Li
On Wed, 19 Feb 2025 at 09:53, Michael Paquier wrote: > On Tue, Feb 18, 2025 at 12:46:50PM +0900, Michael Paquier wrote: >> You are right, obviously. The only reason why this is not showing up >> is that the TAP test uses the long option --conninfo. Speaking of >> which, this had better use fat c

Re: test_escape: invalid option -- 'c'

2025-02-18 Thread Michael Paquier
On Tue, Feb 18, 2025 at 12:46:50PM +0900, Michael Paquier wrote: > You are right, obviously. The only reason why this is not showing up > is that the TAP test uses the long option --conninfo. Speaking of > which, this had better use fat commas to combine the option/value > pairs in these commands

Re: test_escape: invalid option -- 'c'

2025-02-18 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote: >> When I test test_escape, I find the usage of test_escape declares it >> support -c option, however, when I use it, it complains it is an >> invalid option. >> >> Here is a patch to fix it. > > You are right, o

Re: test_escape: invalid option -- 'c'

2025-02-17 Thread Michael Paquier
On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote: > When I test test_escape, I find the usage of test_escape declares it > support -c option, however, when I use it, it complains it is an > invalid option. > > Here is a patch to fix it. You are right, obviously. The only reason why this