Re: tar-related code in PostgreSQL

2020-07-01 Thread Daniel Gustafsson
> On 29 Jun 2020, at 13:52, Robert Haas wrote: > On Sun, Jun 28, 2020 at 11:24 AM Hamid Akhtar wrote: >> The new status of this patch is: Ready for Committer > > Thanks, but this was committed on June 15th, as per my previous email. > Perhaps I forgot to update the CommitFest application D

Re: tar-related code in PostgreSQL

2020-06-29 Thread Robert Haas
On Sun, Jun 28, 2020 at 11:24 AM Hamid Akhtar wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:not tested > > Th

Re: tar-related code in PostgreSQL

2020-06-28 Thread Hamid Akhtar
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:not tested The patch works perfectly. The new status of this patch is: Ready fo

Re: tar-related code in PostgreSQL

2020-06-15 Thread Robert Haas
On Mon, Apr 27, 2020 at 2:07 PM Robert Haas wrote: > > I'd lean mildly to holding 0002 until after we branch. It probably > > won't break anything, but it probably won't fix anything either. > > True. Committed now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

Re: tar-related code in PostgreSQL

2020-04-27 Thread Robert Haas
On Fri, Apr 24, 2020 at 12:27 PM Tom Lane wrote: > Bleah. Whether or not the nearest copy of tar happens to spit up on > that, it's a clear violation of the POSIX standard for tar files. > I'd vote for back-patching your 0001. Done. > I'd lean mildly to holding 0002 until after we branch. It p

Re: tar-related code in PostgreSQL

2020-04-24 Thread Tom Lane
Robert Haas writes: > We have similar code in many places -- because evidently nobody > thought it would be a good idea to have all the logic for reading and > writing tarfiles in a centralized location rather than having many > copies of it -- and typically it's written to pad the block out to a