On Tue, Sep 15, 2020 at 02:56:40PM +0900, Michael Paquier wrote:
> I have completed the patch with those parts as per the attached. If
> there are any objections or extra opinions, please feel free.
And done with 7307df1.
--
Michael
signature.asc
Description: PGP signature
On Mon, Aug 17, 2020 at 02:15:34PM +0900, Michael Paquier wrote:
> Sounds fine to me as well. The LIMIT TO and EXCEPT clauses are
> optional, so using TailMatches() looks fine.
>
> + else if (TailMatches("FROM", "SERVER", MatchAny, "INTO", MatchAny))
> + COMPLETE_WITH("OPTIONS")
> Shouldn
On Sun, Aug 09, 2020 at 12:33:43PM -0400, Tom Lane wrote:
> I don't see how psql could obtain a "real" list of foreign schemas
> from an arbitrary FDW, even if it magically knew which server the
> user would specify later in the command. So this behavior seems fine.
> It has some usefulness, while
Jeff Janes writes:
> It accidentally (even before this patch) completes "IMPORT FOREIGN SCHEMA"
> with a list of local schemas. This is probably wrong, but I find this
> convenient as I often do this in a loop-back setup where the list of
> foreign schema would be the same as the local ones. So