RE: static global variable openLogOff in xlog.c seems no longer used

2019-01-29 Thread Takashi Menjo
Michael Paquier wrote: > It seems to me that keeping openLogOff is still useful to get a report > about the full chunk area being written if the data gets written in > multiple chunks and fails afterwards. Your patch would modify the > report so as only the area with the partial write is reported.

Re: static global variable openLogOff in xlog.c seems no longer used

2019-01-28 Thread Michael Paquier
On Tue, Jan 29, 2019 at 11:49:37AM +0900, Takashi Menjo wrote: > Because of pg_pwrite()[1], openLogOff, a static global variable in xlog.c, > seems taken over by a local variable startoffset and no longer used > now. It seems to me that keeping openLogOff is still useful to get a report about the