On Thu, Feb 1, 2024 at 1:36 AM Richard Guo wrote:
>
>
> On Thu, Feb 1, 2024 at 11:37 AM David Rowley wrote:
>>
>> On Thu, 1 Feb 2024 at 16:29, Richard Guo wrote:
>> > On Thu, Feb 1, 2024 at 10:04 AM James Coleman wrote:
>> >> I don't see any inherent reason why we must always assume that
>> >>
On Thu, Feb 1, 2024 at 5:03 PM David Rowley wrote:
> On Thu, 1 Feb 2024 at 19:36, Richard Guo wrote:
> > maybe we can add an Assert or a comment clarifying that the pathlist of
> > partially_grouped_rel cannot be empty here.
>
> There'd be no need to Assert that as set_cheapest() will raise an
>
On Thu, 1 Feb 2024 at 19:36, Richard Guo wrote:
> maybe we can add an Assert or a comment clarifying that the pathlist of
> partially_grouped_rel cannot be empty here.
There'd be no need to Assert that as set_cheapest() will raise an
error when given a rel with an empty pathlist.
I don't think p
On Thu, Feb 1, 2024 at 11:37 AM David Rowley wrote:
> On Thu, 1 Feb 2024 at 16:29, Richard Guo wrote:
> > On Thu, Feb 1, 2024 at 10:04 AM James Coleman wrote:
> >> I don't see any inherent reason why we must always assume that
> >> gather_grouping_paths will always result in having at least one
On Thu, 1 Feb 2024 at 16:29, Richard Guo wrote:
>
>
> On Thu, Feb 1, 2024 at 10:04 AM James Coleman wrote:
>>
>> I don't see any inherent reason why we must always assume that
>> gather_grouping_paths will always result in having at least one entry
>> in pathlist. If, for example, we've disabled
On Thu, Feb 1, 2024 at 10:04 AM James Coleman wrote:
> I don't see any inherent reason why we must always assume that
> gather_grouping_paths will always result in having at least one entry
> in pathlist. If, for example, we've disabled incremental sort and the
> cheapest partial path happens to
