Re: set relispartition when attaching child index

2019-05-07 Thread Amit Langote
On 2019/04/26 23:12, Alvaro Herrera wrote: > On 2019-Apr-25, Amit Langote wrote: > >> BTW, this will need to be back-patched to 11. > > Done, thanks for the patch. I added the test in master, but obviously > it doesn't work in pg11, so I just verified manually that relispartition > is set correc

Re: set relispartition when attaching child index

2019-04-26 Thread Alvaro Herrera
On 2019-Apr-25, Amit Langote wrote: > BTW, this will need to be back-patched to 11. Done, thanks for the patch. I added the test in master, but obviously it doesn't work in pg11, so I just verified manually that relispartition is set correctly. I don't think it's worth doing more, though there

Re: set relispartition when attaching child index

2019-04-24 Thread Amit Langote
On 2019/04/25 0:55, Amit Langote wrote: > On Thu, Apr 25, 2019 at 12:39 AM Amit Langote wrote: >> On Thu, Apr 25, 2019 at 12:38 AM Amit Langote >> wrote: >>> On Thu, Apr 25, 2019 at 12:35 AM Alvaro Herrera >>> wrote: On 2019-Apr-25, Amit Langote wrote: > It seems that DefineIndex(

Re: set relispartition when attaching child index

2019-04-24 Thread Amit Langote
On Thu, Apr 25, 2019 at 12:39 AM Amit Langote wrote: > On Thu, Apr 25, 2019 at 12:38 AM Amit Langote wrote: > > On Thu, Apr 25, 2019 at 12:35 AM Alvaro Herrera > > wrote: > > > On 2019-Apr-25, Amit Langote wrote: > > > > > > > It seems that DefineIndex() is forgetting to update_relispartition()

Re: set relispartition when attaching child index

2019-04-24 Thread Amit Langote
On Thu, Apr 25, 2019 at 12:38 AM Amit Langote wrote: > On Thu, Apr 25, 2019 at 12:35 AM Alvaro Herrera > wrote: > > On 2019-Apr-25, Amit Langote wrote: > > > > > It seems that DefineIndex() is forgetting to update_relispartition() > > > on a partition's index when it's attached to an index being

Re: set relispartition when attaching child index

2019-04-24 Thread Amit Langote
On Thu, Apr 25, 2019 at 12:35 AM Alvaro Herrera wrote: > On 2019-Apr-25, Amit Langote wrote: > > > It seems that DefineIndex() is forgetting to update_relispartition() > > on a partition's index when it's attached to an index being added to > > the parent. That results in unexpected behavior when

Re: set relispartition when attaching child index

2019-04-24 Thread Alvaro Herrera
On 2019-Apr-25, Amit Langote wrote: > It seems that DefineIndex() is forgetting to update_relispartition() > on a partition's index when it's attached to an index being added to > the parent. That results in unexpected behavior when adding a foreign > key referencing the parent. BTW, maybe Index

Re: set relispartition when attaching child index

2019-04-24 Thread Alvaro Herrera
On 2019-Apr-25, Amit Langote wrote: > It seems that DefineIndex() is forgetting to update_relispartition() > on a partition's index when it's attached to an index being added to > the parent. That results in unexpected behavior when adding a foreign > key referencing the parent. Ah, thanks for f