Re: segmentation fault when cassert enabled

2019-12-19 Thread Jehan-Guillaume de Rorthais
On Wed, 18 Dec 2019 08:46:01 +0530 Amit Kapila wrote: > On Tue, Dec 17, 2019 at 6:01 PM vignesh C wrote: > > > > On Tue, Dec 17, 2019 at 10:09 AM Amit Kapila > > wrote: > > > > > > Attached patch with updated commit message based on suggestions. I am > > > planning to commit this tomorrow un

Re: segmentation fault when cassert enabled

2019-12-17 Thread Amit Kapila
On Tue, Dec 17, 2019 at 6:01 PM vignesh C wrote: > > On Tue, Dec 17, 2019 at 10:09 AM Amit Kapila wrote: > > > > Attached patch with updated commit message based on suggestions. I am > > planning to commit this tomorrow unless there are more comments. > > > > While testing the patch on back vers

Re: segmentation fault when cassert enabled

2019-12-17 Thread vignesh C
On Tue, Dec 17, 2019 at 10:09 AM Amit Kapila wrote: > > On Mon, Dec 16, 2019 at 9:16 PM Jehan-Guillaume de Rorthais > wrote: > > > > On Mon, 16 Dec 2019 13:27:43 +0100 > > Peter Eisentraut wrote: > > > > > On 2019-12-16 11:11, Amit Kapila wrote: > > > > I agree that this is a timing issue. I al

Re: segmentation fault when cassert enabled

2019-12-16 Thread Amit Kapila
On Mon, Dec 16, 2019 at 9:16 PM Jehan-Guillaume de Rorthais wrote: > > On Mon, 16 Dec 2019 13:27:43 +0100 > Peter Eisentraut wrote: > > > On 2019-12-16 11:11, Amit Kapila wrote: > > > I agree that this is a timing issue. I also don't see a way to write > > > a reproducible test for this. Howeve

Re: segmentation fault when cassert enabled

2019-12-16 Thread Jehan-Guillaume de Rorthais
On Mon, 16 Dec 2019 13:27:43 +0100 Peter Eisentraut wrote: > On 2019-12-16 11:11, Amit Kapila wrote: > > I agree that this is a timing issue. I also don't see a way to write > > a reproducible test for this. However, I could reproduce it via > > debugger consistently by following the below step

Re: segmentation fault when cassert enabled

2019-12-16 Thread Jehan-Guillaume de Rorthais
On Fri, 13 Dec 2019 12:10:07 +0530 vignesh C wrote: > On Fri, Dec 6, 2019 at 5:30 PM Amit Kapila wrote: > > > > On Mon, Nov 25, 2019 at 8:25 PM Jehan-Guillaume de Rorthais > > wrote: > > > > > > On Wed, 6 Nov 2019 14:34:38 +0100 > > > Peter Eisentraut wrote: > > > > > > > On 2019-11-05 17:

Re: segmentation fault when cassert enabled

2019-12-16 Thread Peter Eisentraut
On 2019-12-16 11:11, Amit Kapila wrote: I agree that this is a timing issue. I also don't see a way to write a reproducible test for this. However, I could reproduce it via debugger consistently by following the below steps. I have updated a few comments and commit messages in the attached pat

Re: segmentation fault when cassert enabled

2019-12-16 Thread Amit Kapila
On Fri, Dec 13, 2019 at 12:10 PM vignesh C wrote: > > I have made changes to fix the comment provided. The patch for the > same is attached. Could not add a test case for this scenario is based > on timing issue. > Thoughts? > I agree that this is a timing issue. I also don't see a way to write

Re: segmentation fault when cassert enabled

2019-12-12 Thread vignesh C
On Fri, Dec 6, 2019 at 5:30 PM Amit Kapila wrote: > > On Mon, Nov 25, 2019 at 8:25 PM Jehan-Guillaume de Rorthais > wrote: > > > > On Wed, 6 Nov 2019 14:34:38 +0100 > > Peter Eisentraut wrote: > > > > > On 2019-11-05 17:29, Jehan-Guillaume de Rorthais wrote: > > > > My best bet so far is that lo

Re: segmentation fault when cassert enabled

2019-12-06 Thread Amit Kapila
On Mon, Nov 25, 2019 at 8:25 PM Jehan-Guillaume de Rorthais wrote: > > On Wed, 6 Nov 2019 14:34:38 +0100 > Peter Eisentraut wrote: > > > On 2019-11-05 17:29, Jehan-Guillaume de Rorthais wrote: > > > My best bet so far is that logicalrep_relmap_invalidate_cb is not called > > > after the DDL on th

Re: segmentation fault when cassert enabled

2019-11-25 Thread Jehan-Guillaume de Rorthais
On Wed, 6 Nov 2019 14:34:38 +0100 Peter Eisentraut wrote: > On 2019-11-05 17:29, Jehan-Guillaume de Rorthais wrote: > > My best bet so far is that logicalrep_relmap_invalidate_cb is not called > > after the DDL on the subscriber so the relmap cache is not invalidated. So > > we end up with slot->

Re: segmentation fault when cassert enabled

2019-11-12 Thread Jehan-Guillaume de Rorthais
On Mon, 28 Oct 2019 16:47:02 +0900 (JST) Kyotaro Horiguchi wrote: > At Fri, 25 Oct 2019 12:28:38 -0400, Tom Lane wrote in > > Jehan-Guillaume de Rorthais writes: > > > When investigating for the bug reported in thread "logical replication - > > > negative bitmapset member not allowed", I fou

Re: segmentation fault when cassert enabled

2019-11-06 Thread Peter Eisentraut
On 2019-11-05 17:29, Jehan-Guillaume de Rorthais wrote: My best bet so far is that logicalrep_relmap_invalidate_cb is not called after the DDL on the subscriber so the relmap cache is not invalidated. So we end up with slot->tts_tupleDescriptor->natts superior than rel->remoterel->natts in slot_s

Re: segmentation fault when cassert enabled

2019-11-05 Thread Jehan-Guillaume de Rorthais
On Fri, 25 Oct 2019 12:28:38 -0400 Tom Lane wrote: > Jehan-Guillaume de Rorthais writes: > > When investigating for the bug reported in thread "logical replication - > > negative bitmapset member not allowed", I found a way to seg fault > > postgresql only when cassert is enabled. > > ... > > I

Re: segmentation fault when cassert enabled

2019-10-28 Thread Kyotaro Horiguchi
At Fri, 25 Oct 2019 12:28:38 -0400, Tom Lane wrote in > Jehan-Guillaume de Rorthais writes: > > When investigating for the bug reported in thread "logical replication - > > negative bitmapset member not allowed", I found a way to seg fault > > postgresql > > only when cassert is enabled. > > ..

Re: segmentation fault when cassert enabled

2019-10-25 Thread Tom Lane
Jehan-Guillaume de Rorthais writes: > When investigating for the bug reported in thread "logical replication - > negative bitmapset member not allowed", I found a way to seg fault postgresql > only when cassert is enabled. > ... > I hadn't time to digg further yet. However, I don't understand why