Re: seems like a bug in pgbench -R

2019-07-26 Thread Tom Lane
Fabien COELHO writes: >> |...] So I'll mark this ready for committer. > Ok, thanks for the review. LGTM, pushed. regards, tom lane

RE: seems like a bug in pgbench -R

2019-07-24 Thread Fabien COELHO
Hello Yoshikazu, |...] So I'll mark this ready for committer. Ok, thanks for the review. -- Fabien.

RE: seems like a bug in pgbench -R

2019-07-24 Thread Imai, Yoshikazu
On Wed, July 24, 2019 at 7:02 PM, Fabien COELHO wrote: > > but I have one question. Is it better adding any check like if(maxsock > > != -1) before the select? > > > > else/* no explicit delay, select without timeout */ > > { > >nsocks = select(maxsock + 1, &input_mask, NULL, NU

RE: seems like a bug in pgbench -R

2019-07-24 Thread Fabien COELHO
Hello Yoshikazu, I could not reproduce this issue on head, but I confirm on 11.2. I could reproduce the stuck on 11.4. Attached is a fix to apply on pg11. I confirm the stuck doesn't happen after applying your patch. Ok, thanks for the feedback. + /* under throttling we

RE: seems like a bug in pgbench -R

2019-07-24 Thread Imai, Yoshikazu
Hi Fabien, On Fri, Mar 15, 2019 at 4:17 PM, Fabien COELHO wrote: > >> echo 'select 1' > select.sql > >> > >> while /bin/true; do > >> pgbench -n -f select.sql -R 1000 -j 8 -c 8 -T 1 > /dev/null 2>&1; > >> date; > >> done; > > > > Indeed. I'll look at it over the weekend. > > > >> So I guess thi

Re: seems like a bug in pgbench -R

2019-03-16 Thread Fabien COELHO
Hello Tomas, So I guess this is a bug in 12788ae49e1933f463bc59a6efe46c4a01701b76, or one of the other commits touching this part of the code. I could not reproduce this issue on head, but I confirm on 11.2. AFAICS on head it's fixed by 3bac77c48f166b9024a5ead984df73347466ae12 Thanks for

Re: seems like a bug in pgbench -R

2019-03-15 Thread Tomas Vondra
On 3/15/19 5:16 PM, Fabien COELHO wrote: > >>> echo 'select 1' > select.sql >>> >>> while /bin/true; do >>>  pgbench -n -f select.sql -R 1000 -j 8 -c 8 -T 1 > /dev/null 2>&1; >>>  date; >>> done; >> >> Indeed. I'll look at it over the weekend. >> >>> So I guess this is a bug in 12788ae49e1933f463b

Re: seems like a bug in pgbench -R

2019-03-15 Thread Fabien COELHO
echo 'select 1' > select.sql while /bin/true; do pgbench -n -f select.sql -R 1000 -j 8 -c 8 -T 1 > /dev/null 2>&1; date; done; Indeed. I'll look at it over the weekend. So I guess this is a bug in 12788ae49e1933f463bc59a6efe46c4a01701b76, or one of the other commits touching this part of

Re: seems like a bug in pgbench -R

2019-03-15 Thread Fabien COELHO
echo 'select 1' > select.sql while /bin/true; do pgbench -n -f select.sql -R 1000 -j 8 -c 8 -T 1 > /dev/null 2>&1; date; done; Indeed. I'll look at it over the weekend. So I guess this is a bug in 12788ae49e1933f463bc59a6efe46c4a01701b76, or one of the other commits touching this part of