Re: remove_useless_groupby_columns is too enthusiastic

2022-10-11 Thread Michael Paquier
On Fri, Sep 16, 2022 at 12:22:08PM +1200, David Rowley wrote: > We'd probably still want to keep preprocess_groupclause() as > get_useful_group_keys_orderings() is not exhaustive in its search. This thread has been idle for a few weeks now with a review posted, so I have marked the patch as RwF. -

Re: remove_useless_groupby_columns is too enthusiastic

2022-09-15 Thread David Rowley
On Wed, 13 Jul 2022 at 05:31, Tom Lane wrote: > I tried the attached quick-hack patch that just prevents > remove_useless_groupby_columns from removing anything that > appears in ORDER BY. That successfully fixes the complained-of > case, and it doesn't change any existing regression test results

Re: remove_useless_groupby_columns is too enthusiastic

2022-07-14 Thread Richard Guo
On Wed, Jul 13, 2022 at 1:31 AM Tom Lane wrote: > I tried the attached quick-hack patch that just prevents > remove_useless_groupby_columns from removing anything that > appears in ORDER BY. That successfully fixes the complained-of > case, and it doesn't change any existing regression test resu

Re: remove_useless_groupby_columns is too enthusiastic

2022-07-12 Thread David Rowley
On Wed, 13 Jul 2022 at 05:31, Tom Lane wrote: > I tried the attached quick-hack patch that just prevents > remove_useless_groupby_columns from removing anything that > appears in ORDER BY. That successfully fixes the complained-of > case, and it doesn't change any existing regression test results