Re: relcache sometimes initially ignores has_generated_stored

2020-02-06 Thread Andres Freund
On 2020-02-06 21:29:58 +0100, Peter Eisentraut wrote: > On 2020-01-15 19:11, Andres Freund wrote: > > /* > > * Set up constraint/default info > > */ > > if (has_not_null || ndef > 0 || > > attrmiss || relation->rd_rel->relchecks) > > test, i.e. there are no defaults. >

Re: relcache sometimes initially ignores has_generated_stored

2020-02-06 Thread Peter Eisentraut
On 2020-01-15 19:11, Andres Freund wrote: /* * Set up constraint/default info */ if (has_not_null || ndef > 0 || attrmiss || relation->rd_rel->relchecks) test, i.e. there are no defaults. It does still strike me as not great that we can get a d

Re: relcache sometimes initially ignores has_generated_stored

2020-01-15 Thread Kyotaro Horiguchi
At Wed, 15 Jan 2020 10:11:05 -0800, Andres Freund wrote in > Hi, > > I think it's probably not relevant, but it confused me for a moment > that RelationBuildTupleDesc() might set constr->has_generated_stored to > true, but then throw away the constraint at the end, because nothing > matches the