Re: relcache not invalidated when ADD PRIMARY KEY USING INDEX

2022-01-22 Thread Tom Lane
"Euler Taveira" writes: > On Mon, Dec 20, 2021, at 3:45 AM, houzj.f...@fujitsu.com wrote: >> When reviewing some replica identity related patches, I found that when >> adding >> primary key using an existing unique index on not null columns, the >> target table's relcache won't be invalidated. >

Re: relcache not invalidated when ADD PRIMARY KEY USING INDEX

2022-01-13 Thread Julien Rouhaud
Hi, On Mon, Dec 20, 2021 at 06:45:33AM +, houzj.f...@fujitsu.com wrote: > > I tried to write a patch to fix this by invalidating the relcache after > marking > primary key in index_constraint_create(). The cfbot reports that you have a typo in your regression tests: https://api.cirrus-ci.c

Re: relcache not invalidated when ADD PRIMARY KEY USING INDEX

2021-12-20 Thread Euler Taveira
On Mon, Dec 20, 2021, at 3:45 AM, houzj.f...@fujitsu.com wrote: > Hi, > > When reviewing some replica identity related patches, I found that when adding > primary key using an existing unique index on not null columns, the > target table's relcache won't be invalidated. Good catch. It seems you c