Re: regression coverage gaps for gist and hash indexes

2023-04-17 Thread Alexander Lakhin
Hi, 31.03.2023 17:00, Alexander Lakhin wrote: 31.03.2023 15:55, Tom Lane wrote: See also the thread about bug #16329 [1]. Alexander promised to look into improving the test coverage in this area, maybe he can keep an eye on the WAL logic coverage too. Yes, I'm going to analyze that area too.

Re: regression coverage gaps for gist and hash indexes

2023-04-02 Thread Andres Freund
Hi, On 2023-04-02 13:03:51 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-04-02 12:38:32 -0400, Tom Lane wrote: > >> If they have to run serially then that means that their runtime > >> contributes 1-for-1 to the total runtime of the core regression tests, > >> which is not nice at al

Re: regression coverage gaps for gist and hash indexes

2023-04-02 Thread Tom Lane
Andres Freund writes: > On 2023-04-02 12:38:32 -0400, Tom Lane wrote: >> If they have to run serially then that means that their runtime >> contributes 1-for-1 to the total runtime of the core regression tests, >> which is not nice at all. > Agreed, it's not nice. At least reasonably quick (74ms

Re: regression coverage gaps for gist and hash indexes

2023-04-02 Thread Andres Freund
Hi, On 2023-04-02 12:38:32 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-04-01 06:02:47 +0200, Drouvot, Bertrand wrote: > >> +1 to put them in gist.sql and hash_index.sql. > > > Unfortunately it turns out that running them in a parallel group reliably > > prevents cleanup of the dea

Re: regression coverage gaps for gist and hash indexes

2023-04-02 Thread Tom Lane
Andres Freund writes: > On 2023-04-01 06:02:47 +0200, Drouvot, Bertrand wrote: >> +1 to put them in gist.sql and hash_index.sql. > Unfortunately it turns out that running them in a parallel group reliably > prevents cleanup of the dead rows, at least on my machine. Thereby preventing > any increa

Re: regression coverage gaps for gist and hash indexes

2023-04-02 Thread Andres Freund
Hi, On 2023-04-01 06:02:47 +0200, Drouvot, Bertrand wrote: > On 4/1/23 1:13 AM, Andres Freund wrote: > > On 2023-03-31 17:00:00 +0300, Alexander Lakhin wrote: > > > 31.03.2023 15:55, Tom Lane wrote: > > > > See also the thread about bug #16329 [1]. Alexander promised to look > > > > into improvin

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Drouvot, Bertrand
Hi, On 4/1/23 1:13 AM, Andres Freund wrote: Hi, On 2023-03-31 17:00:00 +0300, Alexander Lakhin wrote: 31.03.2023 15:55, Tom Lane wrote: See also the thread about bug #16329 [1]. Alexander promised to look into improving the test coverage in this area, maybe he can keep an eye on the WAL logi

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Andres Freund
Hi, On 2023-03-31 17:00:00 +0300, Alexander Lakhin wrote: > 31.03.2023 15:55, Tom Lane wrote: > > See also the thread about bug #16329 [1]. Alexander promised to look > > into improving the test coverage in this area, maybe he can keep an > > eye on the WAL logic coverage too. > > Yes, I'm going

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Andres Freund
Hi, On 2023-03-31 10:45:51 +0300, Andrey Borodin wrote: > On Fri, Mar 31, 2023 at 8:07 AM Andres Freund wrote: > > > > I was working on committing patch 0001 from [1] and was a bit confused about > > some of the changes to the WAL format for gist and hash index vacuum. It > > looked to me that th

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Alexander Lakhin
31.03.2023 15:55, Tom Lane wrote: See also the thread about bug #16329 [1]. Alexander promised to look into improving the test coverage in this area, maybe he can keep an eye on the WAL logic coverage too. Yes, I'm going to analyze that area too. Maybe it'll take more time (a week or two) if I

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Tom Lane
Andrey Borodin writes: > On Fri, Mar 31, 2023 at 8:07 AM Andres Freund wrote: >> Turns out the problem is that we don't reach deletion for hash and gist >> vacuum: > GiST logs deletions in gistXLogUpdate(), which is covered. > gistXLogDelete() is only used for cleaning during page splits. I'd >

Re: regression coverage gaps for gist and hash indexes

2023-03-31 Thread Andrey Borodin
Hi! On Fri, Mar 31, 2023 at 8:07 AM Andres Freund wrote: > > I was working on committing patch 0001 from [1] and was a bit confused about > some of the changes to the WAL format for gist and hash index vacuum. It > looked to me that the changed code just flat out would not work. > > Turns out the