Re: redundant error messages

2020-11-07 Thread Peter Eisentraut
On 2020-11-05 13:27, Peter Eisentraut wrote: A few client tools duplicate error messages already provided by libpq, such as pg_rewind: fatal: could not connect to server: could not connect to server: No such file or directory pg_basebackup: error: could not connect to server: could not connect

Re: redundant error messages

2020-11-05 Thread Alvaro Herrera
On 2020-Nov-05, Isaac Morland wrote: > In principle, the client knows the database name. In practice, if it's > coming from PGDATABASE or via a service configuration, one may be confused > about the database; having the error message be explicit will avoid many > problems. I can easily imagine tha

Re: redundant error messages

2020-11-05 Thread Isaac Morland
On Thu, 5 Nov 2020 at 08:34, Euler Taveira wrote: Is the database name important for this message? You should inform which > database you want to connect for all client tools except pg_dumpall. > Hence, you > already know which database has the connection problem. IMO the pg_dumpall > message sho

Re: redundant error messages

2020-11-05 Thread Euler Taveira
On Thu, 5 Nov 2020 at 09:27, Peter Eisentraut < peter.eisentr...@enterprisedb.com> wrote: > A few client tools duplicate error messages already provided by libpq, > such as > > pg_rewind: fatal: could not connect to server: could not connect to > server: No such file or directory > > Good catch!