Re: psql: fix variable existence tab completion

2024-09-04 Thread Anton A. Melnikov
On 04.09.2024 23:26, Tom Lane wrote: Pushed. I shall now watch the buildfarm from a safe distance. Thanks! I'll be ready to fix possible falls. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: psql: fix variable existence tab completion

2024-09-04 Thread Tom Lane
"Anton A. Melnikov" writes: > On 19.07.2024 01:10, Tom Lane wrote: >> With respect to the other hacks Alexander mentions, maybe we >> could clean some of those out too? I don't recall what platform >> we had in mind there, but we've moved our goalposts on what >> we support pretty far in the last

Re: psql: fix variable existence tab completion

2024-07-20 Thread Anton A. Melnikov
On 19.07.2024 01:10, Tom Lane wrote: Actually, I think we ought to just reject this change. Debian 10 will be two years past EOL before PG 17 ships. So I don't see a reason to support it in the tests anymore. One of the points of such testing is to expose broken platforms, not mask them. Obvi

Re: psql: fix variable existence tab completion

2024-07-18 Thread Tom Lane
"Anton A. Melnikov" writes: > On 06.05.2024 13:19, Alexander Korotkov wrote: >> Now there is a similar workaround in the 010_tab_completion.pl with regex: >> qr/"mixedName\\?" / > I think if there were or will be complaints from users about this behavior in > Debian 10, > then it makes sense to

Re: psql: fix variable existence tab completion

2024-05-07 Thread Anton A. Melnikov
Hi, Alexander! On 06.05.2024 13:19, Alexander Korotkov wrote: The patch attached fix the 010_tab_completion.pl test in the same way like [1]. Thank you for the fix. As I get, the fix teaches 010_tab_completion.pl to tolerate the invalid result of tab completion. Do you think we could fix it

Re: psql: fix variable existence tab completion

2024-05-06 Thread Alexander Korotkov
Hi, Anton! On Mon, May 6, 2024 at 9:05 AM Anton A. Melnikov wrote: > On 14.03.2024 17:57, Alexander Korotkov wrote: > > On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: > >> On 2024-03-03 03:00 +0100, Steve Chavez wrote: > >>> psql has the :{?name} syntax for testing a psql variable existence

Re: psql: fix variable existence tab completion

2024-05-05 Thread Anton A. Melnikov
Hello! On 14.03.2024 17:57, Alexander Korotkov wrote: On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: On 2024-03-03 03:00 +0100, Steve Chavez wrote: psql has the :{?name} syntax for testing a psql variable existence. But currently doing \echo :{?VERB doesn't trigger tab completion. This

Re: psql: fix variable existence tab completion

2024-03-14 Thread Alexander Korotkov
On Sun, Mar 3, 2024 at 5:37 PM Erik Wienhold wrote: > On 2024-03-03 03:00 +0100, Steve Chavez wrote: > > psql has the :{?name} syntax for testing a psql variable existence. > > > > But currently doing \echo :{?VERB doesn't trigger tab completion. > > > > This patch fixes it. I've also included a T

Re: psql: fix variable existence tab completion

2024-03-03 Thread Erik Wienhold
On 2024-03-03 03:00 +0100, Steve Chavez wrote: > psql has the :{?name} syntax for testing a psql variable existence. > > But currently doing \echo :{?VERB doesn't trigger tab completion. > > This patch fixes it. I've also included a TAP test. Thanks. The code looks good, all tests pass, and the