Re: psql: Make SSL info display more compact

2022-03-02 Thread Daniel Gustafsson
> On 1 Mar 2022, at 09:44, Peter Eisentraut > wrote: > I propose a reduced patch that just removes the "bits" display, since that is > redundant with the "cipher" No objections from me. -- Daniel Gustafsson https://vmware.com/

Re: psql: Make SSL info display more compact

2022-03-01 Thread Peter Eisentraut
On 28.02.22 16:12, Tom Lane wrote: Daniel Gustafsson writes: On 28 Feb 2022, at 12:56, Peter Eisentraut wrote: On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote: How about making it show "compression: on" if compression is on, but nothing in the common "off" case? That would work for me.

Re: psql: Make SSL info display more compact

2022-02-28 Thread Tom Lane
Daniel Gustafsson writes: > On 28 Feb 2022, at 12:56, Peter Eisentraut > wrote: >> On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote: >>> How about making it show "compression: on" if compression is on, but >>> nothing in the common "off" case? >> That would work for me. > On POLA grounds I wo

Re: psql: Make SSL info display more compact

2022-02-28 Thread Daniel Gustafsson
> On 28 Feb 2022, at 12:56, Peter Eisentraut > wrote: > On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote: >> Daniel Gustafsson writes: >>> This was originally done, but all client side changes reverted as there >>> still >>> are server versions in production which allow compression. >> How ab

Re: psql: Make SSL info display more compact

2022-02-28 Thread Peter Eisentraut
On 28.02.22 12:21, Michael Paquier wrote: What about that making the information shown version-aware? I would choose to show the compression part only for server versions where it is settable. That might lead to confusing results if you are not connecting to something that is a stock PostgreS

Re: psql: Make SSL info display more compact

2022-02-28 Thread Peter Eisentraut
On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote: Daniel Gustafsson writes: On 28 Feb 2022, at 10:02, Peter Eisentraut wrote: Since support for SSL compression has been removed from PostgreSQL, it doesn't seem sensible to display it anymore. This was originally done, but all client sid

Re: psql: Make SSL info display more compact

2022-02-28 Thread Michael Paquier
On Mon, Feb 28, 2022 at 10:50:01AM +, Dagfinn Ilmari Mannsåker wrote: > Daniel Gustafsson writes: >> On 28 Feb 2022, at 10:02, Peter Eisentraut >> wrote: >> This was originally done, but all client side changes reverted as there still >> are server versions in production which allow compress

Re: psql: Make SSL info display more compact

2022-02-28 Thread Dagfinn Ilmari Mannsåker
Daniel Gustafsson writes: >> On 28 Feb 2022, at 10:02, Peter Eisentraut >> wrote: > >> Since support for SSL compression has been removed from PostgreSQL, it >> doesn't seem sensible to display it anymore. > > This was originally done, but all client side changes reverted as there still > are s

Re: psql: Make SSL info display more compact

2022-02-28 Thread Daniel Gustafsson
> On 28 Feb 2022, at 10:02, Peter Eisentraut > wrote: > Since support for SSL compression has been removed from PostgreSQL, it > doesn't seem sensible to display it anymore. This was originally done, but all client side changes reverted as there still are server versions in production which all