čt 3. 9. 2020 v 0:30 odesílatel Tom Lane napsal:
> Pavel Stehule writes:
> > [ string_to_table-20200825.patch ]
>
> I reviewed this, whacked it around a little, and pushed it.
>
> Possibly the most controversial thing I did was to move the existing
> documentation entry for string_to_array() int
Peter Smith writes:
> On Thu, Sep 3, 2020 at 8:30 AM Tom Lane wrote:
>> The proposed tests seemed mighty duplicative, and they even contained
>> syntax errors, so I didn't believe that they were carefully considered.
> Can you please share examples of what syntax errors were in those
> previous
On Thu, Sep 3, 2020 at 8:30 AM Tom Lane wrote:
> The proposed tests seemed mighty duplicative, and they even contained
> syntax errors, so I didn't believe that they were carefully considered.
Can you please share examples of what syntax errors were in those
previous tests?
Kind Regards,
Peter S
Pavel Stehule writes:
> [ string_to_table-20200825.patch ]
I reviewed this, whacked it around a little, and pushed it.
Possibly the most controversial thing I did was to move the existing
documentation entry for string_to_array() into the string-functions
table. I did not like it one bit that t
út 25. 8. 2020 v 11:19 odesílatel Peter Smith
napsal:
> On Tue, Aug 25, 2020 at 4:58 PM Pavel Stehule
> wrote:
> > When you run ./unused_oids script, then you get this message
> >
> > [pavel@nemesis catalog]$ ./unused_oids
>
> > Patches should use a more-or-less consecutive range of OIDs.
> > B
On Tue, Aug 25, 2020 at 4:58 PM Pavel Stehule wrote:
> When you run ./unused_oids script, then you get this message
>
> [pavel@nemesis catalog]$ ./unused_oids
> Patches should use a more-or-less consecutive range of OIDs.
> Best practice is to start with a random choice in the range 8000-.
>
út 25. 8. 2020 v 1:19 odesílatel Peter Smith napsal:
> Hi.
>
> I have re-checked the string_to_table_20200824.patch.
>
>
>
> On Tue, Aug 25, 2020 at 2:34 AM Pavel Stehule
> wrote:
>
> >> COMMENT (help text)
> >>
> >> +Splits the string at occurrences
> >> +of delimiter and f
Hi.
I have re-checked the string_to_table_20200824.patch.
On Tue, Aug 25, 2020 at 2:34 AM Pavel Stehule wrote:
>> COMMENT (help text)
>>
>> +Splits the string at occurrences
>> +of delimiter and forms the remaining data
>> +into a table with one text type column.
>
po 24. 8. 2020 v 4:19 odesílatel Peter Smith napsal:
> I have re-checked the string_to_table_20200821.patch.
>
> Below is one remaining problem.
>
>
>
> COMMENT (help text)
>
> +Splits the string at occurrences
> +of delimiter and forms the remaining data
> +into a ta
I have re-checked the string_to_table_20200821.patch.
Below is one remaining problem.
COMMENT (help text)
+Splits the string at occurrences
+of delimiter and forms the remaining data
+into a table with one text type column.
+If delimiter is NULL,
+ea
pá 21. 8. 2020 v 11:08 odesílatel Pavel Stehule
napsal:
>
>
> pá 21. 8. 2020 v 9:44 odesílatel Peter Smith
> napsal:
>
>> On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule
>> wrote:
>>
>> > new patch attached
>>
>> Thanks for taking some of my previous review comments.
>>
>> I have re-checked the s
pá 21. 8. 2020 v 9:44 odesílatel Peter Smith napsal:
> On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule
> wrote:
>
> > new patch attached
>
> Thanks for taking some of my previous review comments.
>
> I have re-checked the string_to_table_20200820.patch.
>
> Below are some remaining questions/comme
On Fri, Aug 21, 2020 at 5:21 AM Pavel Stehule wrote:
> new patch attached
Thanks for taking some of my previous review comments.
I have re-checked the string_to_table_20200820.patch.
Below are some remaining questions/comments:
COMMENT (help text)
+Splits the string at occurren
Hi
čt 20. 8. 2020 v 4:07 odesílatel Peter Smith napsal:
> Hi.
>
> I have been looking at the patch: string_to_table-20200706-2.patch
>
> Below are some review comments for your consideration.
>
>
>
> COMMENT func.sgml (style)
>
> +
> +splits string into table using supplied d
ne 5. 7. 2020 v 13:30 odesílatel Pavel Stehule
napsal:
>
>
> pá 5. 6. 2020 v 13:55 odesílatel Pavel Stehule
> napsal:
>
>> Hi
>>
>> čt 4. 6. 2020 v 11:49 odesílatel movead...@highgo.ca
>> napsal:
>>
>>> +{ oid => '2228', descr => 'split delimited text',
>>> + proname => 'string_to_table', pror
pá 5. 6. 2020 v 13:55 odesílatel Pavel Stehule
napsal:
> Hi
>
> čt 4. 6. 2020 v 11:49 odesílatel movead...@highgo.ca
> napsal:
>
>> +{ oid => '2228', descr => 'split delimited text',
>> + proname => 'string_to_table', prorows => '1000', proretset => 't',
>> + prorettype => 'text', proargtypes
Hi
čt 4. 6. 2020 v 11:49 odesílatel movead...@highgo.ca
napsal:
> +{ oid => '2228', descr => 'split delimited text',
> + proname => 'string_to_table', prorows => '1000', proretset => 't',
> + prorettype => 'text', proargtypes => 'text text',
> + prosrc => 'text_to_table' },
> +{ oid => '2282'
+{ oid => '2228', descr => 'split delimited text',
+ proname => 'string_to_table', prorows => '1000', proretset => 't',
+ prorettype => 'text', proargtypes => 'text text',
+ prosrc => 'text_to_table' },
+{ oid => '2282', descr => 'split delimited text with null string',
+ proname => 'string_to_
pá 17. 4. 2020 v 23:29 odesílatel Justin Pryzby
napsal:
> On Fri, Apr 17, 2020 at 07:47:15PM +0200, Pavel Stehule wrote:
> > I propose new function string_to_table. This function is significantly
>
> +1
>
> > +/*
> > + * Add text to result set (table or array). Build a table when set is a
> expec
On Fri, Apr 17, 2020 at 07:47:15PM +0200, Pavel Stehule wrote:
> I propose new function string_to_table. This function is significantly
+1
> +/*
> + * Add text to result set (table or array). Build a table when set is a
> expected or build
> + * a array
as expected (??)
*an* array
> +select st
20 matches
Mail list logo
