On 2019/01/25 2:18, Alvaro Herrera wrote:
> On 2019-Jan-24, Amit Langote wrote:
>
>> A few hunks of the originally proposed patch are attached here as 0001,
>> especially the part which fixes ATAddForeignKeyConstraint to pass the
>> correct value of connoninherit to CreateConstraintEntry (which sh
On 2019-Jan-24, Amit Langote wrote:
> A few hunks of the originally proposed patch are attached here as 0001,
> especially the part which fixes ATAddForeignKeyConstraint to pass the
> correct value of connoninherit to CreateConstraintEntry (which should be
> false for partitioned tables). With th
On 2019-Jan-25, Amit Langote wrote:
> On Fri, Jan 25, 2019 at 12:30 AM Amit Langote wrote:
> > Doesn't the following performDeletion() at the start of
> > ATExecDropConstraint(), through findDependentObject()'s own recursion,
> > take care of deleting *all* constraints, including those of?
>
>
On Fri, Jan 25, 2019 at 12:30 AM Amit Langote wrote:
>
> On Fri, Jan 25, 2019 at 12:08 AM Alvaro Herrera
> wrote:
> > On 2019-Jan-24, Amit Langote wrote:
> >
> > > Thinking more on this, my proposal to rip dependencies between parent and
> > > child constraints altogether to resolve the bug I ini
On Fri, Jan 25, 2019 at 12:08 AM Alvaro Herrera
wrote:
> On 2019-Jan-24, Amit Langote wrote:
>
> > Thinking more on this, my proposal to rip dependencies between parent and
> > child constraints altogether to resolve the bug I initially reported is
> > starting to sound a bit overambitious especia
Hello
On 2019-Jan-24, Amit Langote wrote:
> Thinking more on this, my proposal to rip dependencies between parent and
> child constraints altogether to resolve the bug I initially reported is
> starting to sound a bit overambitious especially considering that we'd
> need to back-patch it (the pat
Hi,
On 2019/01/24 6:13, Alvaro Herrera wrote:
> On 2019-Jan-22, Amit Langote wrote:
>> Done. See the attached patches for HEAD and PG 11.
>
> I'm not quite sure I understand why the one in DefineIndex needs the
> deps but nothing else does. I fear that you added that one just to
> appease the e
On 2019-Jan-22, Amit Langote wrote:
> On 2019/01/22 8:30, Alvaro Herrera wrote:
> > Hi Amit,
> >
> > Will you please rebase 0002? Please add your proposed tests cases to
> > it, too.
>
> Done. See the attached patches for HEAD and PG 11.
I'm not quite sure I understand why the one in DefineIn
On 2019/01/22 8:30, Alvaro Herrera wrote:
> Hi Amit,
>
> Will you please rebase 0002? Please add your proposed tests cases to
> it, too.
Done. See the attached patches for HEAD and PG 11.
Thanks,
Amit
From 432c4551990d0da1c77b6b9523296b0a2a0a5119 Mon Sep 17 00:00:00 2001
From: amit
Date: Tue
Hi Amit,
Will you please rebase 0002? Please add your proposed tests cases to
it, too.
Thanks,
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Pushed now, thanks.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Sat, Jan 19, 2019 at 7:16 AM Alvaro Herrera wrote:
> Thanks, this is better. There were a few other things I didn't like, so
> I updated it. Mostly, two things:
>
> 1. I didn't like a seqscan on pg_trigger, so I turned that into an
> indexed scan on the constraint OID, and then the other two
On 2019-Jan-18, Amit Langote wrote:
> OK, I agree. I have updated the patch to make things work that way.
Thanks, this is better. There were a few other things I didn't like, so
I updated it. Mostly, two things:
1. I didn't like a seqscan on pg_trigger, so I turned that into an
indexed scan o
On 2019/01/18 7:54, Alvaro Herrera wrote:
> On 2019-Jan-09, Amit Langote wrote:
>
>> 1. Foreign keys of partitions stop working correctly after being detached
>> from the parent table
>
>> This happens because the action triggers defined on the PK relation (pk)
>> refers to p as the referencing r
On 2019-Jan-09, Amit Langote wrote:
> 1. Foreign keys of partitions stop working correctly after being detached
> from the parent table
> This happens because the action triggers defined on the PK relation (pk)
> refers to p as the referencing relation. On detaching p1 from p, p1's
> data is no
Hi Amit
On 2019-Jan-09, Amit Langote wrote:
> I noticed a couple of problems with foreign keys on partitioned tables.
Ouch, thanks for reporting. I think 0001 needs a bit of a tweak in pg11
to avoid an ABI break -- I intend to study this one and try to push
early next week. I'm going to see ab
16 matches
Mail list logo
