Re: prevent 006_transfer_modes.pl from leaving files behind

2025-04-08 Thread Nathan Bossart
Committed. -- nathan

Re: prevent 006_transfer_modes.pl from leaving files behind

2025-04-08 Thread Andrew Dunstan
On 2025-04-08 Tu 10:17 AM, Tom Lane wrote: Andrew Dunstan writes: On 2025-04-07 Mo 7:41 PM, Michael Paquier wrote: delete_old_cluster.sh would be left around even if not using a VPATH build with ./configure (your commit message does not mention that). Even if .gitignore discards it, the file

Re: prevent 006_transfer_modes.pl from leaving files behind

2025-04-08 Thread Tom Lane
Andrew Dunstan writes: > On 2025-04-07 Mo 7:41 PM, Michael Paquier wrote: >> delete_old_cluster.sh would be left around even if not using a VPATH >> build with ./configure (your commit message does not mention that). >> Even if .gitignore discards it, the file is here. > I don't think that matter

Re: prevent 006_transfer_modes.pl from leaving files behind

2025-04-08 Thread Andrew Dunstan
On 2025-04-07 Mo 7:41 PM, Michael Paquier wrote: On Mon, Apr 07, 2025 at 04:45:52PM -0500, Nathan Bossart wrote: The other pg_upgrade tests chdir to tmp_check prior to running pg_upgrade to avoid leaving behind delete_old_cluster.{sh,bat}. 006_transfer_modes.pl should, too. However, this tes

Re: prevent 006_transfer_modes.pl from leaving files behind

2025-04-07 Thread Michael Paquier
On Mon, Apr 07, 2025 at 04:45:52PM -0500, Nathan Bossart wrote: > The other pg_upgrade tests chdir to tmp_check prior to running pg_upgrade > to avoid leaving behind delete_old_cluster.{sh,bat}. 006_transfer_modes.pl > should, too. However, this test is a little different because it loops > over