Re: plpython vs _POSIX_C_SOURCE

2023-01-25 Thread Andres Freund
Hi, Pushed the patches. So far no fallout, and hoverfly recovered. I just checked a few of the more odd animals (Illumos, Solaris, old OpenBSD, AIX) that already ran without finding new warnings. There's a few more animals to run before I'll fully relax though. On 2023-01-25 08:31:23 -0500, Ro

Re: plpython vs _POSIX_C_SOURCE

2023-01-25 Thread Robert Haas
On Tue, Jan 24, 2023 at 11:37 PM Tom Lane wrote: > Andres Freund writes: > > Patches attached. > > +1 for 0001. I'm still nervous about 0002. However, maybe the > cases that we had trouble with are legacy issues that nobody cares > about anymore in 2023. We can always look for another answer i

Re: plpython vs _POSIX_C_SOURCE

2023-01-25 Thread Andres Freund
Hi, On 2023-01-24 23:37:44 -0500, Tom Lane wrote: > Andres Freund writes: > > Patches attached. > > +1 for 0001. Cool, will push tomorrow. > I'm still nervous about 0002. However, maybe the cases that we had trouble > with are legacy issues that nobody cares about anymore in 2023. We can >

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Tom Lane
Andres Freund writes: > Patches attached. +1 for 0001. I'm still nervous about 0002. However, maybe the cases that we had trouble with are legacy issues that nobody cares about anymore in 2023. We can always look for another answer if we get complaints, I guess. regard

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Andres Freund
Hi, On 2023-01-24 18:32:46 -0800, Andres Freund wrote: > > I ran out of energy to test on aix with xlc, I spent way more time on this > > than I have already. I'll pick it up later. > > Building in the background now. Also passes. Thus I think getting rid of the #undefines is the best plan goi

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Andres Freund
Hi, On 2023-01-24 17:48:56 -0800, Andres Freund wrote: > Also for autoconf, I needed to link > $prefix/lib/python3.11/config-3.11/libpython3.11.a > to > $prefix/lib/libpython3.11.a > That might be a python version difference or be related to building python > with --enable-shared - but I see saw o

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Andres Freund
Hi, On 2023-01-24 16:16:06 -0500, Tom Lane wrote: > Andres Freund writes: > > Python's _POSIX_C_SOURCE value is set to a specific value in their configure > > script: > > > if test $define_xopen_source = yes > > then > > ... > > AC_DEFINE(_POSIX_C_SOURCE, 200809L, Define to activate features

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Tom Lane
Andres Freund writes: > Python's _POSIX_C_SOURCE value is set to a specific value in their configure > script: > if test $define_xopen_source = yes > then > ... > AC_DEFINE(_POSIX_C_SOURCE, 200809L, Define to activate features from IEEE > Stds 1003.1-2008) > fi Hm. I looked into Python 3.2

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Andres Freund
Hi, On 2023-01-24 12:55:15 -0500, Tom Lane wrote: > Andres Freund writes: > > The background for the undefines is that _POSIX_C_SOURCE needs to be defined > > the same for the whole compilation, not change in the middle, and Python.h > > defines it. To protect "our" parts a11cf433413 instituted t

Re: plpython vs _POSIX_C_SOURCE

2023-01-24 Thread Tom Lane
Andres Freund writes: > The background for the undefines is that _POSIX_C_SOURCE needs to be defined > the same for the whole compilation, not change in the middle, and Python.h > defines it. To protect "our" parts a11cf433413 instituted the rule that all > postgres headers have to be included fir