Re: plpgsql test layout

2017-12-13 Thread Peter Eisentraut
On 12/12/17 22:59, Michael Paquier wrote: > Attached is what I have some up with, based on Peter's v2. This has been committed. Thanks! -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: plpgsql test layout

2017-12-12 Thread Michael Paquier
On Wed, Dec 13, 2017 at 6:36 AM, Tom Lane wrote: > Peter Eisentraut writes: >> On 12/11/17 19:29, Michael Paquier wrote: >>> If I read vcregress.pl correctly, it seems to me that you need to do >>> more with MSVC (see plcheck). The tests would kick if sql/ and >>> expected/ are found, and the tes

Re: plpgsql test layout

2017-12-12 Thread Tom Lane
Peter Eisentraut writes: > On 12/11/17 19:29, Michael Paquier wrote: >> If I read vcregress.pl correctly, it seems to me that you need to do >> more with MSVC (see plcheck). The tests would kick if sql/ and >> expected/ are found, and the test list is fetched by looking at >> REGRESSION in the tes

Re: plpgsql test layout

2017-12-12 Thread Peter Eisentraut
On 12/11/17 19:29, Michael Paquier wrote: > If I read vcregress.pl correctly, it seems to me that you need to do > more with MSVC (see plcheck). The tests would kick if sql/ and > expected/ are found, and the test list is fetched by looking at > REGRESSION in the test files. However plpgsql code ha

Re: plpgsql test layout

2017-12-11 Thread Michael Paquier
On Tue, Dec 12, 2017 at 5:11 AM, Tom Lane wrote: > Peter Eisentraut writes: >> On 12/7/17 15:21, Pavel Stehule wrote: >>> 2017-12-07 20:08 GMT+01:00 Peter Eisentraut >>> >> >: Here is a first attempt. > >>> looks ok > >> Any other thoughts on this? I

Re: plpgsql test layout

2017-12-11 Thread Tom Lane
Peter Eisentraut writes: > On 12/7/17 15:21, Pavel Stehule wrote: >> 2017-12-07 20:08 GMT+01:00 Peter Eisentraut >> > >: >>> Here is a first attempt. >> looks ok > Any other thoughts on this? If not, I'd like to commit it, give the > buildfarm a run at i

Re: plpgsql test layout

2017-12-11 Thread Peter Eisentraut
On 12/7/17 15:21, Pavel Stehule wrote: > 2017-12-07 20:08 GMT+01:00 Peter Eisentraut > >: > > On 11/14/17 11:51, Pavel Stehule wrote: > >     One option would be to create a new test setup under > src/pl/pgsql(/src) > >     and move some of th

Re: plpgsql test layout

2017-12-07 Thread Pavel Stehule
2017-12-07 20:08 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 11/14/17 11:51, Pavel Stehule wrote: > > One option would be to create a new test setup under > src/pl/pgsql(/src) > > and move some of the test material from the main test suite there. > Some > > of

Re: plpgsql test layout

2017-12-07 Thread Peter Eisentraut
On 11/14/17 11:51, Pavel Stehule wrote: > One option would be to create a new test setup under src/pl/pgsql(/src) > and move some of the test material from the main test suite there.  Some > of the test cases in the main test suite are more about SPI and triggers > and such, so it m

Re: plpgsql test layout

2017-11-14 Thread Pavel Stehule
2017-11-14 17:18 GMT+01:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > Something that has been bothering me for a while, while we have neatly > organized test files for plperl, plpython, pltcl, the plpgsql tests are > all in one giant file in the main test suite, which makes developmen