On Sun, Oct 22, 2023 at 02:02:45PM -0700, Noah Misch wrote:
> - /* OK, do it */
> - brinsummarize(indexRel, heapRel, heapBlk, true, &numSummarized, NULL);
> + /* see gin_clean_pending_list() */
> + if (indexRel->rd_index->indisvalid)
> + brinsummarize(indexRel, heapRel,
On Wed, Oct 04, 2023 at 09:00:23AM +0900, Michael Paquier wrote:
> On Sun, Oct 01, 2023 at 06:31:26PM -0700, Noah Misch wrote:
> > The !indisvalid index may be missing tuples, yes. In what way does that
> > make
> > one of those four operations incorrect?
>
> Reminding myself of what these four
On Sun, Oct 01, 2023 at 06:31:26PM -0700, Noah Misch wrote:
> The !indisvalid index may be missing tuples, yes. In what way does that make
> one of those four operations incorrect?
Reminding myself of what these four do, it looks that you're right and
that the state of indisvalid is not going to
On Mon, Oct 02, 2023 at 09:24:33AM +0900, Michael Paquier wrote:
> On Sun, Oct 01, 2023 at 04:20:42PM -0700, Peter Geoghegan wrote:
> > On Sun, Oct 1, 2023 at 2:00 PM Noah Misch wrote:
> >> [brin_desummarize_range brin_summarize_new_values brin_summarize_range
> >> gin_clean_pending_list] currentl
On Sun, Oct 1, 2023 at 5:24 PM Michael Paquier wrote:
> > FWIW, amcheck's handling of unlogged relations when in hot standby
> > mode is based on the following theory: if recovery were to end, the
> > index would become an empty index, so just treat it as if it was
> > already empty during recover
On Sun, Oct 01, 2023 at 04:20:42PM -0700, Peter Geoghegan wrote:
> On Sun, Oct 1, 2023 at 2:00 PM Noah Misch wrote:
> > Okay. If no other preferences appear, I'll do pgstatindex that way.
>
> Sounds reasonable.
>
>> [pgstatginindex pgstathashindex pgstattuple] currently succeed. Like
>> pgstat
On Sun, Oct 1, 2023 at 2:00 PM Noah Misch wrote:
> Okay. If no other preferences appear, I'll do pgstatindex that way.
Sounds reasonable.
> [pgstatginindex pgstathashindex pgstattuple] currently succeed. Like
> pgstatindex, they should ERROR, including in the back branches.
Makes sense.
> [b
On Sun, Oct 01, 2023 at 04:37:25PM -0400, Tom Lane wrote:
> Noah Misch writes:
> > Running pgstatindex on some !indisready indexes fails with "ERROR: XX001:
> > could not read block 0 in file". This reproduces it:
> > ...
> > Since XX001 = ERRCODE_DATA_CORRUPTED appears in the "can't-happen" cla
Noah Misch writes:
> Running pgstatindex on some !indisready indexes fails with "ERROR: XX001:
> could not read block 0 in file". This reproduces it:
> ...
> Since XX001 = ERRCODE_DATA_CORRUPTED appears in the "can't-happen" class, it's
> not a good fit for this scenario. I propose to have pgst
