Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Bruce Momjian
On Fri, Jan 5, 2018 at 08:39:46PM -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-01-05 18:57:55 -0500, Bruce Momjian wrote: > >> On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote: > >>> Also, leaving translatability aside, why was *any* of this backpatched? > > >> Tom has

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Tom Lane
Andres Freund writes: > On 2018-01-05 18:57:55 -0500, Bruce Momjian wrote: >> On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote: >>> Also, leaving translatability aside, why was *any* of this backpatched? >> Tom has preferred that I backpatch all safe patches so we keep that code >> c

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Andres Freund
On 2018-01-05 18:57:55 -0500, Bruce Momjian wrote: > On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote: > > On 2018-01-05 14:20:59 -0500, Robert Haas wrote: > > > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > > > > pg_upgrade: simplify code layout in a few places > > > > > >

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Bruce Momjian
On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote: > On 2018-01-05 14:20:59 -0500, Robert Haas wrote: > > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > > > pg_upgrade: simplify code layout in a few places > > > > > > Backpatch-through: 9.4 (9.3 didn't need improving) > > > >

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Andres Freund
On 2018-01-05 14:20:59 -0500, Robert Haas wrote: > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > > pg_upgrade: simplify code layout in a few places > > > > Backpatch-through: 9.4 (9.3 didn't need improving) > > Hmm. We don't normally do things like this, because it breaks > translatab

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Bruce Momjian
On Fri, Jan 5, 2018 at 02:37:58PM -0500, Robert Haas wrote: > On Fri, Jan 5, 2018 at 2:32 PM, Alvaro Herrera > wrote: > > Bruce Momjian wrote: > >> On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: > >> > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > >> > > pg_upgrade: simp

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Bruce Momjian
On Fri, Jan 5, 2018 at 02:31:51PM -0500, Robert Haas wrote: > On Fri, Jan 5, 2018 at 2:24 PM, Bruce Momjian wrote: > > On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: > >> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > >> > pg_upgrade: simplify code layout in a few places >

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Robert Haas
On Fri, Jan 5, 2018 at 2:32 PM, Alvaro Herrera wrote: > Bruce Momjian wrote: >> On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: >> > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: >> > > pg_upgrade: simplify code layout in a few places >> > > >> > > Backpatch-through: 9.4 (9.3

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Alvaro Herrera
Bruce Momjian wrote: > On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: > > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > > > pg_upgrade: simplify code layout in a few places > > > > > > Backpatch-through: 9.4 (9.3 didn't need improving) > > > > Hmm. We don't normally do th

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Robert Haas
On Fri, Jan 5, 2018 at 2:24 PM, Bruce Momjian wrote: > On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: >> On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: >> > pg_upgrade: simplify code layout in a few places >> > >> > Backpatch-through: 9.4 (9.3 didn't need improving) >> >> Hmm

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Bruce Momjian
On Fri, Jan 5, 2018 at 02:20:59PM -0500, Robert Haas wrote: > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > > pg_upgrade: simplify code layout in a few places > > > > Backpatch-through: 9.4 (9.3 didn't need improving) > > Hmm. We don't normally do things like this, because it breaks

Re: pgsql: pg_upgrade: simplify code layout in a few places

2018-01-05 Thread Robert Haas
On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian wrote: > pg_upgrade: simplify code layout in a few places > > Backpatch-through: 9.4 (9.3 didn't need improving) Hmm. We don't normally do things like this, because it breaks translatability. -- Robert Haas EnterpriseDB: http://www.enterprisedb.co