On Wed, Jan 25, 2023 at 02:41:18PM -0800, Nathan Bossart wrote:
> This is my preference. If Michael and Robert are okay with it, I think
> this is what we should do. Else, I'll create separate basic_archive and
> basic_restore modules.
Grouping both things into the same module has the advantage
On Wed, Jan 25, 2023 at 01:58:01PM -0800, Andres Freund wrote:
> I think it'd be just fine to keep the name as basic_archive and use it for
> both archiving and restoring. Restoring from an archive still deals with
> archiving.
This is my preference. If Michael and Robert are okay with it, I thin
On Wed, Jan 25, 2023 at 04:50:22PM -0500, Tom Lane wrote:
> Nathan Bossart writes:
>> I wanted to merge basic_archive and basic_recovery because there's a decent
>> chunk of duplicated code.
>
> Would said code likely be duplicated into non-test uses of this feature?
> If so, maybe you ought to f
Hi,
On 2023-01-25 14:05:39 -0500, Robert Haas wrote:
> > I wanted to merge basic_archive and basic_recovery because there's a decent
> > chunk of duplicated code. Perhaps that is okay, but I would rather just
> > have one test module. AFAICT the biggest reason to split it is because we
> > can't
Nathan Bossart writes:
> I wanted to merge basic_archive and basic_recovery because there's a decent
> chunk of duplicated code.
Would said code likely be duplicated into non-test uses of this feature?
If so, maybe you ought to factor it out into a common location. I agree
with Robert's point th
On Wed, Jan 25, 2023 at 02:05:39PM -0500, Robert Haas wrote:
> On Wed, Jan 25, 2023 at 1:17 PM Nathan Bossart
> wrote:
>> I wanted to merge basic_archive and basic_recovery because there's a decent
>> chunk of duplicated code. Perhaps that is okay, but I would rather just
>> have one test module
On Wed, Jan 25, 2023 at 1:17 PM Nathan Bossart wrote:
> On Wed, Jan 25, 2023 at 12:49:45PM -0500, Robert Haas wrote:
> > On Wed, Jan 25, 2023 at 12:37 AM Michael Paquier
> > wrote:
> >> Rename contrib module basic_archive to basic_wal_module
> >
> > FWIW, I find this new name much less clear tha
On Wed, Jan 25, 2023 at 12:49:45PM -0500, Robert Haas wrote:
> On Wed, Jan 25, 2023 at 12:37 AM Michael Paquier wrote:
>> Rename contrib module basic_archive to basic_wal_module
>
> FWIW, I find this new name much less clear than the old one.
>
> If we want to provide a basic_archive module and
On Wed, Jan 25, 2023 at 12:37 AM Michael Paquier wrote:
> Rename contrib module basic_archive to basic_wal_module
FWIW, I find this new name much less clear than the old one.
If we want to provide a basic_archive module and a basic_recovery
module, that seems fine. Why merge them?
--
Robert Ha
