Re: pgsql: Move scanint8() to numutils.c

2022-02-16 Thread Julien Rouhaud
Hi, On Wed, Feb 16, 2022 at 08:24:31AM -0500, Robert Haas wrote: > On Wed, Feb 16, 2022 at 6:09 AM Peter Eisentraut > wrote: > > I don't think we have ever systematically release-noted backend API > > changes. I don't know whether that would be useful, but a complete > > treatment would be a sig

Re: pgsql: Move scanint8() to numutils.c

2022-02-16 Thread Robert Haas
On Wed, Feb 16, 2022 at 6:09 AM Peter Eisentraut wrote: > I don't think we have ever systematically release-noted backend API > changes. I don't know whether that would be useful, but a complete > treatment would be a significant effort (speaking from experience of > porting the mentioned pglogic

Re: pgsql: Move scanint8() to numutils.c

2022-02-16 Thread Peter Eisentraut
On 15.02.22 20:00, Joe Conway wrote: I'm not saying it is hard to fix, but it seems a bit cavalier to not even discuss the potential for breakage. If nothing else we should flag this as something for the release notes. I don't think we have ever systematically release-noted backend API change

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Tom Lane
Robert Haas writes: > On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: >> scanint8() is exported, and this change breaks at least two extensions I >> maintain. > I don't have a particularly strong view on whether the underlying > change was a good idea here, but the breakage you're talking abo

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/15/22 13:47, Robert Haas wrote: On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: (moving to hackers) I guess shame on me for not noticing the thread, but I don't see any discussion about the potential for breakage to external projects. scanint8() is exported, and this change breaks at

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Robert Haas
On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: > (moving to hackers) > > I guess shame on me for not noticing the thread, but I don't see any > discussion about the potential for breakage to external projects. > > scanint8() is exported, and this change breaks at least two extensions I > maint

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/14/22 16:18, Peter Eisentraut wrote: Move scanint8() to numutils.c Move scanint8() to numutils.c and rename to pg_strtoint64(). We already have a "16" and "32" version of that, and the code inside the functions was aligned, so this move makes all three versions consistent. The API is also