Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-15 Thread Jacob Champion
On Tue, May 14, 2024 at 11:15 PM Peter Eisentraut wrote: > > On 15.05.24 02:00, Michael Paquier wrote: > > Is that a recent regression? I have some blurry memories from > > working on these areas that changing src/common/ reflected on the > > compiled pieces effectively at some point. > > One ins

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-14 Thread Peter Eisentraut
On 15.05.24 02:00, Michael Paquier wrote: On Tue, May 14, 2024 at 10:39:36AM +0200, Peter Eisentraut wrote: I saw the same thing. The problem is that there is incomplete dependency information in the makefiles (not meson) between src/common/ and what is using it. So whenever anything changes i

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-14 Thread Michael Paquier
On Tue, May 14, 2024 at 10:39:36AM +0200, Peter Eisentraut wrote: > I saw the same thing. The problem is that there is incomplete dependency > information in the makefiles (not meson) between src/common/ and what is > using it. So whenever anything changes in src/common/, you pretty much have > t

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-14 Thread Peter Eisentraut
On 10.05.24 14:23, Alvaro Herrera wrote: On 2024-May-10, Alvaro Herrera wrote: Not sure what's going on here, or why it fails for me while the buildfarm is all happy. Ah, I ran 'git clean -dfx' and now it works correctly. I must have had an incomplete rebuild. I saw the same thing. The pr

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-12 Thread Michael Paquier
On Fri, May 10, 2024 at 02:23:09PM +0200, Alvaro Herrera wrote: > Ah, I ran 'git clean -dfx' and now it works correctly. I must have had > an incomplete rebuild. I am going to assume that this is an incorrect build. It seems to me that src/common/ was compiled with a past version not sufficient

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-10 Thread Alvaro Herrera
On 2024-May-10, Alvaro Herrera wrote: > Not sure what's going on here, or why it fails for me while the > buildfarm is all happy. Ah, I ran 'git clean -dfx' and now it works correctly. I must have had an incomplete rebuild. -- Álvaro Herrera PostgreSQL Developer — https://www.Enterpr

Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence

2024-05-10 Thread Alvaro Herrera
On 2024-May-09, Michael Paquier wrote: > Fix overread in JSON parsing errors for incomplete byte sequences I'm getting this error in the new test: t/002_inline.pl 1/? # Failed test 'incomplete UTF-8 sequence, chunk size 3: correct error output' # at t/002_inline.pl