Re: pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-21 Thread Alvaro Herrera
Alvaro Herrera wrote: > Alvaro Herrera wrote: > > Alvaro Herrera wrote: > > > Fix CommandCounterIncrement in partition-related DDL > > > > Hmm, Prion seems unhappy about this. Looking > > Here's a patch that seems to fix the problem, and generally looks sane > to me. Pushed, after editing a cou

Re: pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-20 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > I wonder about adding a syscache callback so that when an item in > > pg_partitioned_table is invalidated, the relcache entry for partrelid > > entry in pg_class is invalidated also. I can't find any precedent for > > anything similar, though, and ther

Re: pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-20 Thread Tom Lane
Alvaro Herrera writes: > I wonder about adding a syscache callback so that when an item in > pg_partitioned_table is invalidated, the relcache entry for partrelid > entry in pg_class is invalidated also. I can't find any precedent for > anything similar, though, and there doesn't seem to be any c

Re: pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-20 Thread Alvaro Herrera
Alvaro Herrera wrote: > Alvaro Herrera wrote: > > Fix CommandCounterIncrement in partition-related DDL > > Hmm, Prion seems unhappy about this. Looking Here's a patch that seems to fix the problem, and generally looks sane to me. The previous arrangements to avoid CCI seem brittle: apparently w