Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-07-06 Thread Arseny Sher
Alvaro Herrera writes: > I just don't see it that VACUUM FULL would change the xmin of anything > to FrozenXid, and in my experiments it doesn't. Did you mean VACUUM > FREEZE? Well, docs for VACUUM say: FREEZE Selects aggressive “freezing” of tuples. Specifying FREEZE is equivalent

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-07-05 Thread Alvaro Herrera
Thanks for the detective work! I pushed this test change. (I still don't quite understand what you mean with the freezing part, though.) -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-07-05 Thread Alvaro Herrera
Hi Arseny. I'm writing a commit message to push this test change, and I can't explain this bit: On 2018-Jul-02, Arseny Sher wrote: > 3) As a side note, answer to my question 'why do we get different errors >with VACUUM and VACUUM FULL' is the following. With VACUUM FULL, not >only old pg

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-07-02 Thread Arseny Sher
Arseny Sher writes: > There is also one thing that puzzles me as I don't know much about > vacuum internals. If I do plain VACUUM of pg_attribute in the test, it > shouts "catalog is missing 1 attribute(s) for relid" error (which is > quite expected), while with 'VACUUM FULL pg_attribute' the tu

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-30 Thread Arseny Sher
Tom Lane writes: > Alvaro Herrera writes: >>> On 2018-Jun-28, Tom Lane wrote: According to buildfarm member friarbird, and as confirmed here, the contrib/test_decoding/specs/oldest_xmin.spec test added by this commit fails under CLOBBER_CACHE_ALWAYS. > >> I suppose 60 seconds (is

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-29 Thread Tom Lane
Alvaro Herrera writes: >> On 2018-Jun-28, Tom Lane wrote: >>> According to buildfarm member friarbird, and as confirmed here, >>> the contrib/test_decoding/specs/oldest_xmin.spec test added by this >>> commit fails under CLOBBER_CACHE_ALWAYS. > I suppose 60 seconds (isolationtester's default time

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-29 Thread Alvaro Herrera
On 2018-Jun-29, Alvaro Herrera wrote: > On 2018-Jun-28, Tom Lane wrote: > > > Alvaro Herrera writes: > > > Fix "base" snapshot handling in logical decoding > > > > According to buildfarm member friarbird, and as confirmed here, > > the contrib/test_decoding/specs/oldest_xmin.spec test added by

Re: pgsql: Fix "base" snapshot handling in logical decoding

2018-06-29 Thread Alvaro Herrera
On 2018-Jun-28, Tom Lane wrote: > Alvaro Herrera writes: > > Fix "base" snapshot handling in logical decoding > > According to buildfarm member friarbird, and as confirmed here, > the contrib/test_decoding/specs/oldest_xmin.spec test added by this > commit fails under CLOBBER_CACHE_ALWAYS. Hm.