Re: pgsql: Clean up warnings from -Wimplicit-fallthrough.

2018-05-03 Thread Peter Eisentraut
On 5/1/18 23:33, Tom Lane wrote: > Andres Freund writes: >> On 2018-05-01 23:35:18 +, Tom Lane wrote: >>> Clean up warnings from -Wimplicit-fallthrough. > >> I found one more oddity with the current committed state: ... >> It seems that gcc gets confused by the #ifdef ECONNRESET. > > Yeah, t

Re: pgsql: Clean up warnings from -Wimplicit-fallthrough.

2018-05-01 Thread Tom Lane
Andres Freund writes: > On 2018-05-01 23:35:18 +, Tom Lane wrote: >> Clean up warnings from -Wimplicit-fallthrough. > I found one more oddity with the current committed state: ... > It seems that gcc gets confused by the #ifdef ECONNRESET. Yeah, there's a gcc bug or three about that: https:

Re: pgsql: Clean up warnings from -Wimplicit-fallthrough.

2018-05-01 Thread Andres Freund
On 2018-05-01 17:32:39 -0700, Andres Freund wrote: > Hi, > > On 2018-05-01 23:35:18 +, Tom Lane wrote: > > Clean up warnings from -Wimplicit-fallthrough. > > > > Recent gcc can warn about switch-case fall throughs that are not > > explicitly labeled as intentional. This seems like a good thi

Re: pgsql: Clean up warnings from -Wimplicit-fallthrough.

2018-05-01 Thread Andres Freund
Hi, On 2018-05-01 23:35:18 +, Tom Lane wrote: > Clean up warnings from -Wimplicit-fallthrough. > > Recent gcc can warn about switch-case fall throughs that are not > explicitly labeled as intentional. This seems like a good thing, > so clean up the warnings exposed thereby by labeling all su