Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-07 Thread Michael Paquier
On Thu, Sep 06, 2018 at 05:18:10PM +0100, Andrew Gierth wrote: > Yeah; I checked the other constructs I used for what version they were > added in, but that one slipped through. Fix coming shortly. For the sake of the archives, Andrew has pushed 7b6b167 to address the issue, which looks fine at qu

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-06 Thread Andrew Gierth
> "Tom" == Tom Lane writes: > Andrew Gierth writes: >> Consulting old manuals suggests it may have version 3.80 (c. 2002), >> which lacks the 'else if..' syntax introduced in 3.81 (c. 2006). Tom> Right; I haven't updated it because that's specifically called out to Tom> be the minimum

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-06 Thread Tom Lane
Andrew Gierth writes: > Consulting old manuals suggests it may have version 3.80 (c. 2002), > which lacks the 'else if..' syntax introduced in 3.81 (c. 2006). Right; I haven't updated it because that's specifically called out to be the minimum supported version in our docs (cf installation.sgml).

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-06 Thread Tom Lane
Andrew Gierth writes: > "Michael" == Michael Paquier writes: > Michael> prairiedog is unhappy with this commit: > What version of GNU Make is on there, do you know? Tom? I don't see it > mentioned in the output anywhere. $ make -v GNU Make 3.80 Copyright (C) 2002 Free Software Foundation, Inc

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-05 Thread Andrew Gierth
> "Michael" == Michael Paquier writes: >> What version of GNU Make is on there, do you know? Tom? I don't see >> it mentioned in the output anywhere. Michael> I don't know it. Consulting old manuals suggests it may have version 3.80 (c. 2002), which lacks the 'else if..' syntax introduce

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-05 Thread Michael Paquier
On Thu, Sep 06, 2018 at 06:26:51AM +0100, Andrew Gierth wrote: > What version of GNU Make is on there, do you know? Tom? I don't see it > mentioned in the output anywhere. I don't know it. What I can see is that the use of "else ifdef" is forbidden. You could bypass the problem with more ifdef-o

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-05 Thread Andrew Gierth
> "Michael" == Michael Paquier writes: Michael> prairiedog is unhappy with this commit: What version of GNU Make is on there, do you know? Tom? I don't see it mentioned in the output anywhere. -- Andrew.

Re: pgsql: Allow extensions to install built as well as unbuilt headers.

2018-09-05 Thread Michael Paquier
Hi Andrew, On Wed, Sep 05, 2018 at 09:45:49PM +, Andrew Gierth wrote: > Allow extensions to install built as well as unbuilt headers. > > Commit df163230b overlooked the case that an out-of-tree extension > might need to build its header files (e.g. via ./configure). If it is > also doing a V