On 2020-Apr-13, Fabien COELHO wrote:
> Alvaro's feedback was about the lack of "pg_strndup" availability, but he
> concluded that it would seldom be used if available, so it was not worth the
> effort to add it for the sake of this small patch.
Hello. Please note that as is often the case, I was
Bonjour Michaël,
On Mon, Nov 30, 2020 at 12:53:20PM +0100, Fabien COELHO wrote:
Not in the short term, but probably for the next CF. Can you park it there?
IMO, I think that it would be better to leave this item marked as RwF
for now if you are not sure, and register it again in the CF once
Sure, I'll move it to the next CF then. I also noticed, that the first
message mentions the idea of refactoring to use some code it in both
pgbench and psql code. Can you, please, share a link to the thread, if
it exists?
Unsure. I'll try to find it if it exists.
--
Fabien.
On 30.11.2020 14:53, Fabien COELHO wrote:
The new status of this patch is: Waiting on Author
This patch was inactive during the commitfest, so I am going to mark
it as "Returned with Feedback".
Fabien, are you planning to continue working on it?
Not in the short term, but probably for the
On Mon, Nov 30, 2020 at 12:53:20PM +0100, Fabien COELHO wrote:
> Not in the short term, but probably for the next CF. Can you park it there?
IMO, I think that it would be better to leave this item marked as RwF
for now if you are not sure, and register it again in the CF once
there is an actual ne
The new status of this patch is: Waiting on Author
This patch was inactive during the commitfest, so I am going to mark it as
"Returned with Feedback".
Fabien, are you planning to continue working on it?
Not in the short term, but probably for the next CF. Can you park it
there?
--
Fab
On 20.10.2020 15:22, Ibrar Ahmed wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: tested, failed
Documentation:not tested
I am not very convinced to have
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: tested, failed
Documentation:not tested
I am not very convinced to have that, but I have performed some testing o
Bonjour Michaël,
Hmm. It seems to me that this stuff needs to be more careful with the
function handling? For example, all those cases fail but they directly
pass down a variable that may not be defined, so shouldn't those results
be undefined as well instead of failing:
\set g double(:{
On Mon, Apr 13, 2020 at 09:54:01AM +0200, Fabien COELHO wrote:
> Attached a v4. I'm resurrecting this small patch, after "\aset" has been
> added to pgbench (9d8ef988).
Hmm. It seems to me that this stuff needs to be more careful with the
function handling? For example, all those cases fail but
Bonjour Michaël,
Patch v3 is also a rebase.
This has rotten for half a year, so I am marking it as returned with
feedback. There have been comments from Alvaro and Andres as well...
Attached a v4. I'm resurrecting this small patch, after "\aset" has been
added to pgbench (9d8ef988).
Alv
On Tue, Mar 27, 2018 at 02:08:31PM +0200, Fabien COELHO wrote:
>> Patch v2 is a rebase.
>
> Patch v3 is also a rebase.
This has rotten for half a year, so I am marking it as returned with
feedback. There have been comments from Alvaro and Andres as well...
--
Michael
signature.asc
Description:
Patch v2 is a rebase.
Patch v3 is also a rebase.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index 41d9030..7b3badf 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/sgml/ref/pgbench.sgml
@@ -971,6 +971,8 @@ pgbench options
d
integer c
While investigating moving pgbench expressions to fe_utils so that they can
be shared with psql (\if ..., \let ?), I figure out that psql's \if has a
syntax to test whether a variable exists, which is not yet available to
pgbench.
This patch adds the same syntax to pgbench expression so that
re. pg_strndup() the following places could use it (skim of a very quick grep
for pg_strdup):
src/bin/pg_waldump/pg_waldump.c:*dir = pg_strdup(path);
src/bin/pg_waldump/pg_waldump.c-(*dir)[(sep - path) + 1] = '\0';/*
no strndup */
src/bin/psql/prompt.c: n
Note that it is not really that useful for benchmarking, although it does
not harm.
That seems plenty reason to plainly reject this patch? If we end up
unifying it'll be added via that, no?
On the contrary, my point is to add the feature beforehand so that it is
not intermixed in the large
Hi,
On 2018-02-19 19:23:04 +0100, Fabien COELHO wrote:
> Note that it is not really that useful for benchmarking, although it does
> not harm.
That seems plenty reason to plainly reject this patch? If we end up
unifying it'll be added via that, no?
- Andres
17 matches
Mail list logo
