Committed, after pgindent. Thanks Fabien and Ibrar.
Thanks for the commit.
--
Fabien.
On Fri, Jul 12, 2019 at 4:20 AM Fabien COELHO wrote:
> >>> Now the patch is good now.
> >>>
> >>> The new status of this patch is: Ready for Committer
> >
> > Why aren't we instead putting the exact scripts in the documentation?
> > Having to call pgbench with a special flag to get the script text
Hello Andrew,
Now the patch is good now.
The new status of this patch is: Ready for Committer
Why aren't we instead putting the exact scripts in the documentation?
Having to call pgbench with a special flag to get the script text seems
a bit odd.
A typical use case I had is to create a ne
On 5/2/19 12:35 PM, Fabien COELHO wrote:
>
>> Now the patch is good now.
>>
>> The new status of this patch is: Ready for Committer
>
> Ok, thanks.
>
Why aren't we instead putting the exact scripts in the documentation?
Having to call pgbench with a special flag to get the script text seems
a b
Now the patch is good now.
The new status of this patch is: Ready for Committer
Ok, thanks.
--
Fabien.
Now the patch is good now.
The new status of this patch is: Ready for Committer
Hello,
Patch looks good to me, and work fine on my machine. One minor
observation is option 'list' mostly used to list the elements like
"pgbench -b list" shows the available builtin scripts. Therefore we
should use a word which seems to be more relevant like --show-script.
Thanks for the r
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Patch looks good to me, and work fine on my machine. One mino
