Re: pg_upgrade not preserving comments on predefined roles

2021-05-06 Thread Chapman Flack
On 05/02/21 19:25, Tom Lane wrote: > Chapman Flack writes: >> I've appended the comments we use for them at $work, anyway. > > IMO these would have to be shortened quite a bit to be friendly for > "\du+" displays. I'm not against the concept though. I'm certainly not wedded to the exact wording

Re: pg_upgrade not preserving comments on predefined roles

2021-05-02 Thread Tom Lane
Chapman Flack writes: > Is there an inherent technical or policy reason for pg_upgrade not to > preserve comments on predefined roles (or on predefined objects generally)? I think this is absolutely out of scope for pg_dump. We generally expect that system objects' properties are not dumped, bec