Re: pg_upgrade from 9.4 to 10.4

2018-08-05 Thread Bruce Momjian
On Sat, Aug 4, 2018 at 11:26:06PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Fri, Aug 3, 2018 at 04:56:32PM -0400, Bruce Momjian wrote: > >> On Fri, Aug 3, 2018 at 01:55:04PM -0400, Tom Lane wrote: > >>> Right now is probably not a good time to fix this, but it seems like > >>> somet

Re: pg_upgrade from 9.4 to 10.4

2018-08-04 Thread Tom Lane
Bruce Momjian writes: > On Fri, Aug 3, 2018 at 04:56:32PM -0400, Bruce Momjian wrote: >> On Fri, Aug 3, 2018 at 01:55:04PM -0400, Tom Lane wrote: >>> Right now is probably not a good time to fix this, but it seems like >>> something that could be improved. I'd be kind of inclined to remove >>>

Re: pg_upgrade from 9.4 to 10.4

2018-08-04 Thread Bruce Momjian
On Fri, Aug 3, 2018 at 04:56:32PM -0400, Bruce Momjian wrote: > On Fri, Aug 3, 2018 at 01:55:04PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > The comment at the top of src/port/system.c explains why we need those > > > quotes. Spaces was not the issue. > > > > So, while starting to

Re: pg_upgrade from 9.4 to 10.4

2018-08-03 Thread Bruce Momjian
On Fri, Aug 3, 2018 at 01:55:04PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > The comment at the top of src/port/system.c explains why we need those > > quotes. Spaces was not the issue. > > So, while starting to prepare the release notes, I looked at this patch > again and I'm still won

Re: pg_upgrade from 9.4 to 10.4

2018-08-03 Thread Tom Lane
Bruce Momjian writes: > The comment at the top of src/port/system.c explains why we need those > quotes. Spaces was not the issue. So, while starting to prepare the release notes, I looked at this patch again and I'm still wondering why it's designed this way. AFAICS, the current state of affai

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Bruce Momjian
On Tue, Jul 31, 2018 at 08:05:06PM -0400, Andrew Dunstan wrote: > On 07/31/2018 07:08 PM, Bruce Momjian wrote: > >Oh, jacana must be a Windows server with spaces in the file name paths. > >Fixed. Thanks again. I really didn't want to backpatch the original > >fix but had to since it could produce

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Andrew Dunstan
On 07/31/2018 07:08 PM, Bruce Momjian wrote: On Tue, Jul 31, 2018 at 06:29:34PM -0400, Tom Lane wrote: Bruce Momjian writes: On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: This patch evidently broke build farm member jacana, although only in the 9.3 branch. It's been failing wi

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Bruce Momjian
On Tue, Jul 31, 2018 at 06:29:34PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: > >> This patch evidently broke build farm member jacana, although only > >> in the 9.3 branch. It's been failing with > >> Jul 28 23:22:30 The system ca

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Tom Lane
Bruce Momjian writes: > On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: >> This patch evidently broke buildfarm member jacana, although only >> in the 9.3 branch. It's been failing with >> Jul 28 23:22:30 The system cannot find the path specified. > Well, that's interesting. I have a

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Bruce Momjian
On Tue, Jul 31, 2018 at 03:26:47PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Updated patch applied through 9.3: > > > > https://git.postgresql.org/pg/commitdiff/260fe9f2b02b67de1e5ff29faf123e4220586c43 > > This patch evidently broke buildfarm member jacana, although only > in the 9.

Re: pg_upgrade from 9.4 to 10.4

2018-07-31 Thread Tom Lane
Bruce Momjian writes: > Updated patch applied through 9.3: > > https://git.postgresql.org/pg/commitdiff/260fe9f2b02b67de1e5ff29faf123e4220586c43 This patch evidently broke buildfarm member jacana, although only in the 9.3 branch. It's been failing with Jul 28 23:22:29 Performing Consiste

Re: pg_upgrade from 9.4 to 10.4

2018-07-28 Thread Bruce Momjian
On Sat, Jun 23, 2018 at 10:29:49PM -0400, Bruce Momjian wrote: > On Fri, Jun 15, 2018 at 03:01:37PM -0700, Vimalraj A wrote: > > I would like to understand why it happens so.  > > 1. What transient state corrupts the db? > > 2. Is it a known issue with pg_upgrade?  > > 3. Is there a way to get the

Re: pg_upgrade from 9.4 to 10.4

2018-06-23 Thread Bruce Momjian
On Fri, Jun 15, 2018 at 03:01:37PM -0700, Vimalraj A wrote: > Hi, > > After pg_upgrade, the data in Postgres is corrupted.  > > 1. Postgres 9.4, stop db with "immediate" mode > 2. Run pg_upgrade, to upgrade to Postgres 10.4 > 3. Start Postgres 10 and run vacuum full, got a bunch of "concurrent in