Re: pg_upgrade dead code for pre-8.4 versions

2020-10-06 Thread Magnus Hagander
On Tue, Oct 6, 2020 at 8:45 PM Bruce Momjian wrote: > On Tue, Oct 6, 2020 at 11:40:57AM +0200, Daniel Gustafsson wrote: > > > On 6 Oct 2020, at 11:27, Magnus Hagander wrote: > > > > > ISTM that code could be cleaned out, because it should be dead based > on the initial check that we are upgradi

Re: pg_upgrade dead code for pre-8.4 versions

2020-10-06 Thread Bruce Momjian
On Tue, Oct 6, 2020 at 11:40:57AM +0200, Daniel Gustafsson wrote: > > On 6 Oct 2020, at 11:27, Magnus Hagander wrote: > > > ISTM that code could be cleaned out, because it should be dead based on the > > initial check that we are upgrading from 8.4 or later? > > +1. Commit 2209b3923a7afe0b re

Re: pg_upgrade dead code for pre-8.4 versions

2020-10-06 Thread Daniel Gustafsson
> On 6 Oct 2020, at 11:27, Magnus Hagander wrote: > ISTM that code could be cleaned out, because it should be dead based on the > initial check that we are upgrading from 8.4 or later? +1. Commit 2209b3923a7afe0b removed support for 8.3 so anything left checking for pre-8.4 should be removed a