Re: pg_stat_advisor extension

2024-05-13 Thread Ilia Evdokimov
1. In the case of parallel workers the plan_rows value has a different semantics than the number of rows predicted. Just explore get_parallel_divisor(). 2. The extension recommends new statistics immediately upon an error finding. But what if the reason for the error is stale statistics? Or thi

Re: pg_stat_advisor extension

2024-02-08 Thread Ilia Evdokimov
On Feb 08 2024 at 07:14:18, Andrei Lepikhov wrote: 1. In the case of parallel workers the plan_rows value has a different semantics than the number of rows predicted. Just explore get_parallel_divisor(). Yes, this is a very weighty and important issue. I need to think about this very carefully

Re: pg_stat_advisor extension

2024-02-08 Thread Ilia Evdokimov
Our further discussion of this new extension takes place in this thread: https://www.postgresql.org/message-id/flat/f822b674-9697-43b9-931b-4d69729a26ff%40tantorlabs.com .Due to technical difficulties in the current thread, I will not be able to conduct a dialogue except in HTML format. And this wi

Re: pg_stat_advisor extension

2024-02-08 Thread Ilia Evdokimov
On Feb 8 2024 at 00:00:00 jian he >INT MAX >should be 1.0? I don’t know why Konstantin Knizhnik used the ratio of actual tuples to the planned ones, but most who start testing my extension expect that it will be a coefficient from 0 to 1, which will be the ratio of the estimated tuples to th

Re: pg_stat_advisor extension

2024-02-07 Thread Andrei Lepikhov
On 6/2/2024 22:27, Ilia Evdokimov wrote: I welcome your insights, feedback, and evaluations regarding the necessity of integrating this new extension into PostgreSQL. Besides other issues that were immediately raised during the discovery of the extension, Let me emphasize two issues: 1. In the

Re: pg_stat_advisor extension

2024-02-07 Thread jian he
On Tue, Feb 6, 2024 at 12:06 AM Ilia Evdokimov wrote: > > Hi hackers, > > I'm reaching out again regarding the patch with new extension > 'pg_stat_advisor' aimed at enhancing query plan efficiency through the > suggestion of creating statistics. > > I understand the community is busy, but I woul

Re: pg_stat_advisor extension

2024-02-06 Thread Ilia Evdokimov
Dear Team, Firstly, I would like to extend my sincere apologies for the confusion and technical oversights in our previous discussions regarding the 'pg_stat_advisor extension'. To address this and facilitate a clearer, more focused dialogue, I have initiated a new thread to consolidate our d

Re: pg_stat_advisor extension

2024-02-06 Thread Ilia Evdokimov
Hi hackers, I've encountered and addressed errors in the "0001-pg_stat_advisor-extension.patch" when applying it to the main branch, specifically trailing whitespace issues at lines 117 and 118: ``` 0001-pg_stat_advisor-extension.patch:117: trailing whitespace.   

Re: pg_stat_advisor extension

2024-02-05 Thread Ilia Evdokimov
Hi hackers, I'm reaching out again regarding the patch with new extension 'pg_stat_advisor' aimed at enhancing query plan efficiency through the suggestion of creating statistics. I understand the community is busy, but I would greatly value any feedback or thoughts on this extension. Thank you for