Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread Tom Lane
ahsan hadi writes: > I have applied tested both patches separately and ran regression with both. > No new test cases are failing with both patches. > The issues is fixed by both patches however the fix from Tom > (0001-fix-worker-status.patch) looks more elegant. I haven't done a detailed > cod

Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: tested, passed Documentation:not tested I have applied tested both patches separately and ran regression with

Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread vignesh C
On Fri, Jan 31, 2020 at 1:09 AM Tom Lane wrote: > > vignesh C writes: > > On Wed, Jan 29, 2020 at 6:54 PM Ahsan Hadi wrote: > >> Can you share a test case or steps that you are using to reproduce this > >> issue? Are you reproducing this using a debugger? > > > I could reproduce with the follow

Re: pg_restore crash when there is a failure before all child process is created

2020-01-31 Thread Ahsan Hadi
I have applied tested both patches separately and ran regression with both. No new test cases are failing with both patches. The issues is fixed by both patches however the fix from Tom looks more elegant. I haven't done a detailed code review. On Fri, Jan 31, 2020 at 12:39 AM Tom Lane wrote: >

Re: pg_restore crash when there is a failure before all child process is created

2020-01-30 Thread Tom Lane
vignesh C writes: > On Wed, Jan 29, 2020 at 6:54 PM Ahsan Hadi wrote: >> Can you share a test case or steps that you are using to reproduce this >> issue? Are you reproducing this using a debugger? > I could reproduce with the following steps: > Make cluster setup. > Create few tables. > Take a

Re: pg_restore crash when there is a failure before all child process is created

2020-01-29 Thread vignesh C
On Wed, Jan 29, 2020 at 6:54 PM Ahsan Hadi wrote: > > Hi Vignesh, > > Can you share a test case or steps that you are using to reproduce this > issue? Are you reproducing this using a debugger? > I could reproduce with the following steps: Make cluster setup. Create few tables. Take a dump in di