RE: pg_recvlogical requires -d but not described on the documentation

Dear Fujii-san, > I've updated the commit messages for both patches and also revised > the code comments in the 0002 patch. The updated patches are attached. > > Unless there are any objections, I'm thinking to commit them. Thanks for updating the patch. LGTM. Best regards, Hayato Kuroda FUJITS

RE: pg_recvlogical requires -d but not described on the documentation

Dear Fujii-san, > Thanks for the patch! It looks good to me. > > I'm considering whether to back-patch these changes to older versions. > Since pg_recvlogical --drop-slot worked without --dbname in 9.4 > but started failing unintentionally in 9.5, it could be considered a bug. > However, this beh

Re: pg_recvlogical requires -d but not described on the documentation

On 2025/03/21 10:12, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, Thanks for the patch! It looks good to me. I'm considering whether to back-patch these changes to older versions. Since pg_recvlogical --drop-slot worked without --dbname in 9.4 but started failing unintentionally in 9.5, it

RE: pg_recvlogical requires -d but not described on the documentation

Dear hackers, > I've pushed the patches. Thanks! This is a closing post. Fujii-san has pushed patches and no BF failures till now. This patch does not modify the synopsis part, but it is intentional. Per [1], we would discuss the manner for documentations in another thread. I've closed the CF e

Re: pg_recvlogical requires -d but not described on the documentation

On 2025/03/24 11:21, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, I've updated the commit messages for both patches and also revised the code comments in the 0002 patch. The updated patches are attached. Unless there are any objections, I'm thinking to commit them. Thanks for updating t

Re: pg_recvlogical requires -d but not described on the documentation

On 2025/03/19 11:32, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, It looks like commit 0c013e08cfb introduced a bug that causes "pg_recvlogical --drop-slot" without --dbname to check whether it's connected to a specific database and fail if it's not. This commit was added before 9.5, whil

RE: pg_recvlogical requires -d but not described on the documentation

Dear Fujii-san, > It looks like commit 0c013e08cfb introduced a bug that causes "pg_recvlogical > --drop-slot" > without --dbname to check whether it's connected to a specific database and > fail > if it's not. > > This commit was added before 9.5, while pg_recvlogical was introduced in 9.4. >

Re: pg_recvlogical requires -d but not described on the documentation

On 2025/03/18 18:17, Hayato Kuroda (Fujitsu) wrote: Dear Fujii-san, David, BTW, I'm curious why --dbname isn't required for the --drop-slot action. I'm analyzing around here... Actually, replication slots can be dropped from another database where it created, or even from the streaming

Re: pg_recvlogical requires -d but not described on the documentation

On 2025/03/12 14:59, David G. Johnston wrote: On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) mailto:kuroda.hay...@fujitsu.com>> wrote: OK, so I will exclude the point in the thread. The patch I've posted contains all of fixes which is required. The patch fixes the synopsis a

RE: pg_recvlogical requires -d but not described on the documentation

Dear Fujii-san, David, > > BTW, I'm curious why --dbname isn't required for the --drop-slot action. > > I'm analyzing around here... > Actually, replication slots can be dropped from another database where it created, or even from the streaming replication connection. I forked the new thread wh

RE: pg_recvlogical requires -d but not described on the documentation

Dear David, Fujii-san, > I think this is too: > set_pglocale_pgservice(argv[0], PG_TEXTDOMAIN("pg_basebackup")); I think it is intentional. IIUC, it accepts the directory which the file exists. Please see commits fc995bfdbf. Best regards, Hayato Kuroda FUJITSU LIMITED

RE: pg_recvlogical requires -d but not described on the documentation

Dear Fujii-san, Thanks for giving comments and sorry for missing replies. > I agree that the synopsis doesn't need to be updated. Attached patch clarifies > the required options for each action in the documentation. Thought? So, the policy David said is not to modify the synopsis part here, beca

Re: pg_recvlogical requires -d but not described on the documentation

On Monday, March 17, 2025, Fujii Masao wrote: > > On 2025/03/12 14:59, David G. Johnston wrote: > >> On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) < >> kuroda.hay...@fujitsu.com > wrote: >> >> >> OK, so I will exclude the point in the thread. The patc

Re: pg_recvlogical requires -d but not described on the documentation

On Tuesday, March 11, 2025, vignesh C wrote: > > > Apart from the database, I believe the target file also needs to be > specified. Should we include this option also along with dbname: > + > + > + -d > + --dbname > + > +dbname > + > > pg_recvlogical -U postgres --start -

Re: pg_recvlogical requires -d but not described on the documentation

On Monday, February 24, 2025, Hayato Kuroda (Fujitsu) < kuroda.hay...@fujitsu.com> wrote: > > > OK, so I will exclude the point in the thread. The patch I've posted > contains all of fixes > which is required. > The patch fixes the synopsis and the mention of the default value. Only the later is

Re: pg_recvlogical requires -d but not described on the documentation

On Fri, 21 Feb 2025 at 14:25, Hayato Kuroda (Fujitsu) wrote: > > Dear Ashutosh, > > Thanks for the reply. > > > > ISTM the inconsistency is introduced since the initial commit. I think > > > they should > > be unified either > > > 1) update the doc or 2) accept when -d is not specified. Personall

RE: pg_recvlogical requires -d but not described on the documentation

Dear Ashutosh, Thanks for the confirmation! > This looks good to me. It builds with meson. Didn't check make. I confirmed it could be built via make command. > > Hmm, unify the treatment seems clean, but it may break current connection > rules > > for some application. I'm not sure now this is

Re: pg_recvlogical requires -d but not described on the documentation

On Fri, Feb 21, 2025 at 2:25 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Ashutosh, > > Thanks for the reply. > > > > ISTM the inconsistency is introduced since the initial commit. I think > > > they should > > be unified either > > > 1) update the doc or 2) accept when -d is not specified. Persona

RE: pg_recvlogical requires -d but not described on the documentation

Dear Ashutosh, Thanks for the reply. > > ISTM the inconsistency is introduced since the initial commit. I think they > > should > be unified either > > 1) update the doc or 2) accept when -d is not specified. Personally, I like > > 2nd > approach, pg_recvlogical > > can follow the normal connec

Re: pg_recvlogical requires -d but not described on the documentation

On Fri, Feb 21, 2025 at 9:56 AM Hayato Kuroda (Fujitsu) wrote: > > Dear hackers, > > Hi, I found the issue $SUBJECT. According to the doc [1]: > > ``` > -d dbname > --dbname=dbname > The database to connect to. See the description of the actions for what this > means in detail. > The dbname can b