On Wed, Apr 25, 2018 at 06:53:38PM -0700, Noah Misch wrote:
> Right. Done.
Thanks, Noah.
--
Michael
signature.asc
Description: PGP signature
On Wed, Apr 25, 2018 at 03:57:49PM +0200, Magnus Hagander wrote:
> On Mon, Apr 23, 2018 at 12:49 AM, Michael Paquier wrote:
> > On Sun, Apr 22, 2018 at 02:55:51PM -0700, Noah Misch wrote:
> > > That change is testing the wrong variable. I plan to repair it as
> > > attached.
> >
> > You are right
On Mon, Apr 23, 2018 at 12:49 AM, Michael Paquier
wrote:
> On Sun, Apr 22, 2018 at 02:55:51PM -0700, Noah Misch wrote:
> > That change is testing the wrong variable. I plan to repair it as
> > attached.
>
> You are right here. Ditto
>
Ouch indeed. +1 for the fix.
Noah, you are planning to pus
On Sun, Apr 22, 2018 at 02:55:51PM -0700, Noah Misch wrote:
> That change is testing the wrong variable. I plan to repair it as
> attached.
You are right here. Ditto
The whole GetConnection() business in src/bin/pg_basebackup is confusing
with the presence of a global variable. I am wondering
On Tue, Apr 17, 2018 at 03:38:13PM +0900, Michael Paquier wrote:
> On Tue, Apr 17, 2018 at 03:01:33AM -0300, Euler Taveira wrote:
> > A proposed fix is attached. It should be applied to 9.4, 9.5, 9.6, and
> > 10. (Although, client version 10 can connect to server version 10,
> > client version 10 c
2018-04-17 3:38 GMT-03:00 Michael Paquier :
> The exact same fix has already applied on all stable branches:
>
Sorry about the noise. I've only checked the REL9_6_8 tag and the tarball.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Cons
On Tue, Apr 17, 2018 at 03:01:33AM -0300, Euler Taveira wrote:
> A proposed fix is attached. It should be applied to 9.4, 9.5, 9.6, and
> 10. (Although, client version 10 can connect to server version 10,
> client version 10 can't connect to server version 9.6.)
>
> Comments?
The exact same fix h
