Re: pg_dump does not dump domain not-null constraint's comments

2025-05-07 Thread jian he
On Wed, May 7, 2025 at 10:56 PM Álvaro Herrera wrote: > > Ooh, you know what? I ran your the CREATE DOMAIN statement in your new > test and pg_dump'ed that, and as far as I can tell the _name_ of the > not-null constraint is not dumped either. So it's not just the comment > that we're losing. T

Re: pg_dump does not dump domain not-null constraint's comments

2025-05-07 Thread Álvaro Herrera
Ooh, you know what? I ran your the CREATE DOMAIN statement in your new test and pg_dump'ed that, and as far as I can tell the _name_ of the not-null constraint is not dumped either. So it's not just the comment that we're losing. That's a separate bug, and probably needs to be fixed first, altho

Re: pg_dump does not dump domain not-null constraint's comments

2025-05-07 Thread jian he
On Wed, May 7, 2025 at 5:25 PM Álvaro Herrera wrote: > > On 2025-May-07, jian he wrote: > > > in PG17 and master, pg_dump (--schema=test --no-owner) > > [...] > > didn't produce > > COMMENT ON CONSTRAINT nn ON DOMAIN test.d1 IS 'not null constraint on > > domain d1'; > > we should make pg_dump to

Re: pg_dump does not dump domain not-null constraint's comments

2025-05-07 Thread Álvaro Herrera
On 2025-May-07, jian he wrote: > in PG17 and master, pg_dump (--schema=test --no-owner) > [...] > didn't produce > COMMENT ON CONSTRAINT nn ON DOMAIN test.d1 IS 'not null constraint on > domain d1'; > we should make pg_dump to produce it too? Yes, this is clearly a pg17 bug whose fix should be ba