Re: pg_dump: Remove obsolete trigger support

2024-01-09 Thread Tom Lane
I wrote: > However, the patch looks a little incomplete: you did not remove > fetching of all of the now-unneeded values from the SQL queries. Oh, scratch that, I now see that we already did that query optimization. regards, tom lane

Re: pg_dump: Remove obsolete trigger support

2024-01-09 Thread Peter Eisentraut
On 09.01.24 16:27, Tom Lane wrote: Peter Eisentraut writes: In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump. But I found that a lot of dead code was left for supporting dumping triggers from those old versions, presumably because that code was not behind straightforward ver

Re: pg_dump: Remove obsolete trigger support

2024-01-09 Thread Tom Lane
Peter Eisentraut writes: > In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump. > But I found that a lot of dead code was left for supporting dumping > triggers from those old versions, presumably because that code was not > behind straightforward versioned "if" branches. This