Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-07-02 Thread Amit Kapila
On Tue, Jul 2, 2024 at 9:57 AM Shlok Kyal wrote: > > On Mon, 1 Jul 2024 at 11:44, Hayato Kuroda (Fujitsu) > wrote: > > > > Dear Amit, > > > > Thanks for giving comments! PSA new version. > > > > > Thanks, this is a better approach. I have changed a few comments and > > > made some other cosmetic

Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-07-01 Thread Shlok Kyal
On Mon, 1 Jul 2024 at 11:44, Hayato Kuroda (Fujitsu) wrote: > > Dear Amit, > > Thanks for giving comments! PSA new version. > > > Thanks, this is a better approach. I have changed a few comments and > > made some other cosmetic changes. See attached. > > I checked your attached and LGTM. Based on

Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-07-01 Thread Amit Kapila
On Mon, Jul 1, 2024 at 11:44 AM Hayato Kuroda (Fujitsu) wrote: > > > You can create a dummy subscription on node_p > > and do a test similar to what we are doing in "# Create failover slot > > to test its removal". > > Your approach looks better than mine. I followed the approach. > LGTM. -- Wi

RE: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-06-30 Thread Hayato Kuroda (Fujitsu)
Dear Amit, Thanks for giving comments! PSA new version. > Thanks, this is a better approach. I have changed a few comments and > made some other cosmetic changes. See attached. I checked your attached and LGTM. Based on that, I added some changes like below: - Made dbname be escaped while listi

Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-06-28 Thread Amit Kapila
On Thu, Jun 27, 2024 at 11:47 AM Hayato Kuroda (Fujitsu) wrote: > > > It seems disabling subscriptions on the primary can make the primary > > stop functioning for some duration of time. I feel we need some > > solution where after converting to subscriber, we disable and drop > > pre-existing sub

RE: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-06-26 Thread Hayato Kuroda (Fujitsu)
Dear Amit, Vingesh, Thanks for giving comments! > It seems disabling subscriptions on the primary can make the primary > stop functioning for some duration of time. I feel we need some > solution where after converting to subscriber, we disable and drop > pre-existing subscriptions. One idea coul

Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-06-26 Thread Amit Kapila
On Fri, Jun 21, 2024 at 4:51 PM Hayato Kuroda (Fujitsu) wrote: > > This is a follow-up thread for pg_createsubscriber [1]. I started a new thread > since there is no activity around here. > > ## Problem > > Assuming that there is a cascading replication like below: > > node A --(logical replicatio

Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node

2024-06-26 Thread vignesh C
On Fri, 21 Jun 2024 at 16:51, Hayato Kuroda (Fujitsu) wrote: > > Dear Hackers, > > This is a follow-up thread for pg_createsubscriber [1]. I started a new thread > since there is no activity around here. > > ## Problem > > Assuming that there is a cascading replication like below: > > node A --(lo