Re: pg_create_logical_replication_slot argument incongruency

2022-09-20 Thread Florin Irion
Thank you! Il mar 20 set 2022, 12:29 Michael Paquier ha scritto: > On Tue, Sep 20, 2022 at 08:41:56AM +0200, Florin Irion wrote: > > OK, patch only for the docs attached. > > Thanks, applied. > -- > Michael >

Re: pg_create_logical_replication_slot argument incongruency

2022-09-20 Thread Michael Paquier
On Tue, Sep 20, 2022 at 08:41:56AM +0200, Florin Irion wrote: > OK, patch only for the docs attached. Thanks, applied. -- Michael signature.asc Description: PGP signature

Re: pg_create_logical_replication_slot argument incongruency

2022-09-19 Thread Florin Irion
On 20/09/22 03:33, Michael Paquier wrote: > On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote: >> This was introduced in commit 19890a06. >> >> IMHO we should use the documented argument name `two_phase` and change the >> function to accept it. >> >> What do you think? > > 19890a0 is

Re: pg_create_logical_replication_slot argument incongruency

2022-09-19 Thread Michael Paquier
On Mon, Sep 19, 2022 at 07:02:16PM +0200, Florin Irion wrote: > This was introduced in commit 19890a06. > > IMHO we should use the documented argument name `two_phase` and change the > function to accept it. > > What do you think? 19890a0 is included in REL_14_STABLE, and changing an argument na