Re: pg_combinebackup PITR comparison test fix

2024-12-17 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Mon, Dec 16, 2024 at 12:26:38PM +, Dagfinn Ilmari Mannsåker wrote: >> s{create tablespace .* location .*\btspitr\K[12]}{N}i for @_; >> >> I think I'm leaning towards the latter, for simplicity and robustness. > > Simplicity and robustness works here and in the CI

Re: pg_combinebackup PITR comparison test fix

2024-12-16 Thread Michael Paquier
On Mon, Dec 16, 2024 at 12:26:38PM +, Dagfinn Ilmari Mannsåker wrote: > s{create tablespace .* location .*\btspitr\K[12]}{N}i for @_; > > I think I'm leaning towards the latter, for simplicity and robustness. Simplicity and robustness works here and in the CI, so I have used the latter then a

Re: pg_combinebackup PITR comparison test fix

2024-12-16 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Sun, Dec 15, 2024 at 10:34:07AM +0900, Michael Paquier wrote: >> Indeed, good catch. I'll take care of it. Thanks! > +sub { > +s{create tablespace .* location '.*/tspitr\K[12]}{N}i for @_; > +return $_[0] ne $_[1]; > +}); > > The CI is compl

Re: pg_combinebackup PITR comparison test fix

2024-12-15 Thread Michael Paquier
On Sun, Dec 15, 2024 at 10:34:07AM +0900, Michael Paquier wrote: > Indeed, good catch. I'll take care of it. +sub { +s{create tablespace .* location '.*/tspitr\K[12]}{N}i for @_; +return $_[0] ne $_[1]; +}); The CI is complaining on this one because the custom comparison

Re: pg_combinebackup PITR comparison test fix

2024-12-14 Thread Michael Paquier
On Sat, Dec 14, 2024 at 09:57:11PM +, Dagfinn Ilmari Mannsåker wrote: > While I was going through the TAP tests to fix the formatting of command > argument lists to be less confusing, I noticed that pg_combinebackup's > 002_compare_backups.pl test accidentally ran pg_dumpall twice against > the